Page MenuHomeVyOS Platform

undefined var includes_chroot_dir in build-vyos-image
Closed, ResolvedPublicBUG

Description

https://github.com/vyos/vyos-build/blob/3871fb67ec18f841c5168be0b267427efaf74cdb/scripts/build-vyos-image#L415

The variable "includes_chroot_dir" is undefined.
This breaks the execution when a "build-flavor" has sth like:

[[includes_chroot]]
  path = "yyyyy"
  data = '''
xxxxxx
  '''

I guess the var content should be

build/config/includes.chroot/

Details

Version
1.4
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Revisions and Commits

Event Timeline

Well, after a better code reading, the var should be named chroot_includes_dir instead of includes_chroot_dir.

https://github.com/vyos/vyos-build/blob/3871fb67ec18f841c5168be0b267427efaf74cdb/scripts/build-vyos-image#L338

Restricted Repository Identity closed this task as Resolved by committing Restricted Diffusion Commit.Nov 9 2022, 7:46 PM
Restricted Repository Identity added a commit: Restricted Diffusion Commit.
ssasso added a commit: Restricted Diffusion Commit.Nov 9 2022, 7:47 PM