In T3344#87831, @runar wrote:@Viacheslav in you example, what does set protocols bgp <asn> vrf do? if i'm reading it correctly it makes no sense as you do not start a new process, and the ASN for the vrf will be the asn of the global bgp process
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 21 2021
Feb 21 2021
Viacheslav closed T3330: Bgp capability orf prefix-list fail, a subtask of T2174: Rewrite protocol BGP to new XML/Python style, as Resolved.
Viacheslav closed T3331: Bgp unsuppress-map should be as "value leafNode", a subtask of T2174: Rewrite protocol BGP to new XML/Python style, as Resolved.
@Viacheslav in you example, what does set protocols bgp <asn> vrf do? if i'm reading it correctly it makes no sense as you do not start a new process, and the ASN for the vrf will be the asn of the global bgp process
using set protocols ospf vrf ... makes it harder to show that this is actually multiple processes that co-exist on the router, but on the other hand if we are thinking about the config scripts that are going to execute all this the syntax set protocols ospf vrf.... makes more sense, because the normal ospf config_mode script can program both "global" and all the vrf's
There are differences on vrf support in ospf,++ and BGP. the largest difference is that in IGP's you start a new process for each and every vrf you use. then the syntax set protocols vrf ospf.... makes kinda sense, but on BGP you are only using ONE process and the vrf is only a address-family inside the current process. and there the syntax set protocols bgp X vrf X makes most sense.
I prefer more option2
c-po changed the status of T2271: OSPF: add per VRF instance support, a subtask of T2175: Rewriting all FRR processes allow for reloading and to XML/Python style, from Open to Blocked.
c-po changed the status of T2271: OSPF: add per VRF instance support, a subtask of T3344: Per VRF dynamic routing support, from Open to Blocked.
c-po renamed T2271: OSPF: add per VRF instance support from OSPF: add VRF support to OSPF: add per VRF instance support.
c-po added a subtask for T2579: The root task for VRF features: T3344: Per VRF dynamic routing support.
c-po added a parent task for T3344: Per VRF dynamic routing support: T2579: The root task for VRF features.
c-po removed a subtask for T2579: The root task for VRF features: T2271: OSPF: add per VRF instance support.
c-po removed a parent task for T2271: OSPF: add per VRF instance support: T2579: The root task for VRF features.
c-po added a parent task for T2271: OSPF: add per VRF instance support: T3344: Per VRF dynamic routing support.
c-po added a subtask for T3344: Per VRF dynamic routing support: T2271: OSPF: add per VRF instance support.
Feb 20 2021
Feb 20 2021
c-po closed T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500 as Unknown Status.
c-po changed the status of T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500 from In progress to Needs testing.
Which VyOS CLI command enables LRO?
Hi, I have tried these set of configuration and the openvpn connection was up and working fine.
erkin changed the status of T2647: ipsec disableuniqreqids generate a wrong ipsec.conf from Unknown Status to Resolved.
Feb 19 2021
Feb 19 2021
zsdc changed the status of T3338: Some Cloud-Init configurations can prevent login on the router from Open to Confirmed.
I would like to solve this in the next way. I will:
- Add verification to our config module to avoid impossible configurations.
- Add IPv6 gateway processing (how could I miss this? Cannot imagine...).
I saw multiple times configs with a firewall section that contains about a thousand lines, so I do not think that DNS records are something size-critical that deserves additional config files.
I believe that keeping config parts outside the config.boot is a bad idea in general that against our main benefit - single config for everything.
at first glance this looks very interesting. Befor this can be added I would like to give the following comments:
- adding a cli node that passes raw config values from cli to the daemon is bad (we inherited this for dhcp and openvpn and it caused more harm then good in the last 2 years) - is this mandatory?
- even dns using A, AAAA, PTR upper case types we should keep the CLI lowercase - this can be easily handled within the Jinja2 template.
- having > 20 dns records here could really bleow up the CLI, maybe we should thing about loading the zone from a file @zdc @dmbaturin @jestabro?
c-po added a comment to T3332: BGP unnumbered - UnboundLocalError: local variable 'peer_group' referenced before assignment.
Thank you for giving out bleeding edge codebase a spin - I will check this out.
Can we also extend the available BGP smoketests to test this?
Unknown Object (User) edited projects for T3343: Wrong output conntrack-sync status, added: VyOS 1.2 Crux (VyOS 1.2.7); removed VyOS 1.2 Crux.
Unknown Object (User) changed the status of T3343: Wrong output conntrack-sync status from Open to In progress.
Unknown Object (User) created T3343: Wrong output conntrack-sync status.
Viacheslav changed the status of T3330: Bgp capability orf prefix-list fail, a subtask of T2174: Rewrite protocol BGP to new XML/Python style, from Open to Needs testing.
Viacheslav changed the status of T3330: Bgp capability orf prefix-list fail from Open to Needs testing.
tom.siewert added a comment to T3332: BGP unnumbered - UnboundLocalError: local variable 'peer_group' referenced before assignment.
I just tried to set up a new router using /31 transfer networks and this also fails with the same error (no BGP unnumbered).
sever-sever <v.gletenko@vyos.io> committed rVYOSONEXb5f67d4ea18d: bgp: T3330: Fix capability orf prefix-list.
GitHub <noreply@github.com> committed rVYOSONEX4ef293430ac0: Merge pull request #736 from sever-sever/T3330 (authored by c-po).
@ernstjo I can't reproduce it in VyOS 1.4-rolling-202102190541
Viacheslav renamed T3322: Bgp neighbor timers not applyed to FRR config from Bgp timers not applyed to FRR config to Bgp neighbor timers not applyed to FRR config.
Viacheslav changed the status of T3331: Bgp unsuppress-map should be as "value leafNode", a subtask of T2174: Rewrite protocol BGP to new XML/Python style, from Open to Needs testing.
Viacheslav changed the status of T3331: Bgp unsuppress-map should be as "value leafNode" from Open to Needs testing.
sever-sever <v.gletenko@vyos.io> committed rVYOSONEXb576a95b1aa3: bgp: T3331: Fix set unsuppress-map for neighbor.
GitHub <noreply@github.com> committed rVYOSONEX57f3fd3ae8ac: Merge pull request #735 from sever-sever/T3331 (authored by dmbaturin).
Template generate wrong value
https://github.com/vyos/vyos-1x/blob/current/data/templates/frr/bgp.frr.tmpl#L112
haakon.nore added a comment to T3341: Wrong behavior of the "reset vpn ipsec-peer XXX tunnel XXX" command.
I can confirm it is broken for
reset vpn ipsec-peer XXX
too when you run policy-based VPNs.
Peer reset log:
maznu added a comment to T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500.
Sure thing:
c-po added a comment to T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500.
A verify() step will be added to prevent certain configurations when a specific type of driver is used. In this case if the xen driver is used, and MTU is > 1500 and sg is not set, a ConfigError() will be raised.
c-po changed the status of T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500 from Open to In progress.
pasik added a comment to T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts.
Thanks a lot @jestabro ! I'll give it a go with the latest version(s).
maznu renamed T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500 from Must set "scattergather" offload before MTU to On xen-netback interfaces must set "scattergather" offload before MTU>1500.
maznu updated the task description for T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500.
maznu updated the task description for T3342: On xen-netback interfaces must set "scattergather" offload before MTU>1500.
Feb 18 2021
Feb 18 2021
Oh, actually I just noticed this was a duplicate of T562, I should have posted there. Sorry about that :-(
wsapplegate added a comment to T3338: Some Cloud-Init configurations can prevent login on the router.
In T3338#87652, @zsdc wrote:Can you share details about your hypervisor and datasource? Also as the full Cloud-init log (/var/log/cloud-init.log)?
olofl added a comment to T3341: Wrong behavior of the "reset vpn ipsec-peer XXX tunnel XXX" command.
I believe this is the behavior in 1.2.6 aswell?
And I think its not even possible to reset one peer?
So, reset vpn ipsec-peer XXX is broken
as well as reset vpn ipsec-peer XXX tunnel YYY
jestabro changed Is it a breaking change? from none to compatible on T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts.
jestabro moved T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts from In Progress to Finished on the VyOS 1.3 Equuleus board.
jestabro moved T3302: Make vyos-configd relay stdout from scripts to the user's console from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
jestabro closed T3302: Make vyos-configd relay stdout from scripts to the user's console, a subtask of T2347: During commit, any script output directed to stdout will contain path, as Unknown Status.
jestabro closed T3302: Make vyos-configd relay stdout from scripts to the user's console as Unknown Status.
GitHub <noreply@github.com> committed rVYOSONEXd3c9a52e8788: Merge pull request #734 from jestabro/T3302 (authored by jestabro).
If this package supports all existing setups and the GRE usecase I see no reason to not replace it. @basalblas PR is happily accepted.
Can you share details about your hypervisor and datasource? Also as the full Cloud-init log (/var/log/cloud-init.log)?
Either datasource generates a wrong config, either the format is not well described in the Cloud-init documentation - there noted that: "gateway: IPv4 address of the default gateway for this subnet". I more believe in the wrong documentation, but would be better to check.
Independently of this all, the situation is not good, because we need to verify values that put into config. So, this will be fixed in one or another way (proper adding or drop), when we figure out details.
c-po renamed T3238: Update Linux Kernel to v4.19.178 from Update Linux Kernel to v4.19.169 to Update Linux Kernel to v4.19.176.
So I'm unsure how to rewrite that in a clean way, and I would appreciate your and @c-po's opinions on the subject
dhcp-helper is working perfectly fine with GRE tunnels, see my feature request https://phabricator.vyos.net/T3340
basalblas added a project to T3340: Add dhcp-helper package to replace ISC DHCP Relay: VyOS 1.3 Equuleus.
Keep in mind you cannot run dhcp-helper and ISC DHCP server at the same time on a single router. The Vyos CLI should not allow this.
dmbaturin renamed T2759: validate-value prints error messages from validators that fail even if overall validation succeeds from XML: router-advert, bgp: multiple different validators cause error message to pop up even if syntax is valid to validate-value prints error messages from validators that fail even if overall validation succeeds.
jestabro moved T3259: many dnat rules makes the vyos http api crash, even showConfig op timeouts from Open to Finished on the VyOS 1.4 Sagitta board.