The vyos-configd client, vyshim, doesn't relay the stdout/stderr from scripts to the user's console. This is problematic because many scripts have used printing for displaying warnings or debug information.
We need to make sure everything scripts want to tell reaches the user who initiated the commit.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG | jestabro | T2347 During commit, any script output directed to stdout will contain path | ||
| Resolved | jestabro | T3302 Make vyos-configd relay stdout from scripts to the user's console | |||
| Resolved | jestabro | T3411 Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses |
Currently, vyos-configd will explicitly report ConfigError to the console; however, non-fatal warnings or information will not be reported. An example of a non-fatal warning is:
https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/service_pppoe-server.py#L63
Using the context managers redirect_stdout and redirect_stderr from contextlib allows a simple resolution. A link to this approach in testing is below.
One open issue is the absence of the component path, for example [ service pppoe-server ], in non-fatal warnings. This output is prepended by the backend, on interception of stdout, and has caused inconsistencies in the past, unrelated to vyos-configd --- cf. T2347.
Version in testing:
https://github.com/vyos/vyos-1x/compare/current...jestabro:T3302
If commit is not initiated from a 'live' session (for example, on boot), then redirected stdout/err should go to a file.
This task was superseded by T3411, hence was not backported; however that missed the bug fix in the final commit. cherry-pick eeb9687.