Page MenuHomeVyOS Platform
Create Task
Maniphest T2759

validate-value prints error messages from validators that fail even if overall validation succeeds
Closed, ResolvedPublicBUG
Actions

Description

Having the following validation statement in https://github.com/vyos/vyos-1x/blob/current/interface-definitions/service_router-advert.xml.in for e.g.

<leafNode name="valid-lifetime">
  <properties>
    <help>Time in seconds that the prefix will remain valid (default: 30 days)</help>
    <completionHelp>
      <list>infinity</list>
    </completionHelp>
    <valueHelp>
      <format>1-4294967295</format>
      <description>Time in seconds that the prefix will remain valid</description>
    </valueHelp>
    <valueHelp>
      <format>infinity</format>
      <description>Prefix will remain preferred forever</description>
    </valueHelp>
    <constraint>
      <validator name="numeric" argument="--range 0-4294967295"/>
      <regex>(infinity)</regex>
    </constraint>
  </properties>
  <defaultValue>2592000</defaultValue>
</leafNode>

Will print: 'infinity' is not a valid integer number but the value is accepted. How can we both validate a string an an integer for the same node?

Details

Version
1.3-rolling-20200803
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

c-po created this task.Aug 4 2020, 8:22 AM
pasik subscribed.Aug 4 2020, 9:51 AM
Viacheslav subscribed.Aug 4 2020, 5:52 PM

Before adding "<defaultValue>" it was working but not now.

I tried

<constraint>
  <validator name="numeric" argument="--range 0-4294967295"/>
  <validator name="fqdn"/>
  <regex>(infinity)</regex>
</constraint>

2 validators also don't work.

thomas-mangin subscribed.Aug 5 2020, 10:08 AM

I would have expected the output generated to be an OR of the validators or regexes and allow the output if any would have passed it

c-po moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus board.Dec 26 2020, 3:52 PM
dmbaturin subscribed.Dec 31 2020, 2:43 PM

We can add a new <constraintGroup> element. If you put multiple <constraint> elements inside a <constraintGroup>, they work like logical AND.

If you have both <constraint> and <constraintGroup> elements under <properties>, a value must be valid for either that single constraint or the group.

c-po added a comment.Jan 17 2021, 4:31 PM

This actually also happens for BGP which will confuse users

vyos@vyos# set protocols bgp 100 neighbor 1.1.1.1 remote-as internal
    'internal' is not a valid integer number
c-po renamed this task from XML: router-adver: validate both string (regex) and number to XML: router-advert, bgp: multiple different validators cause error message to pop up even if syntax is valid.Jan 17 2021, 4:31 PM
c-po changed the task status from Open to Confirmed.
c-po assigned this task to dmbaturin.
c-po triaged this task as Urgent! priority.
dmbaturin mentioned this in T3321: Bgp not possible to use internal|external remote as.Feb 18 2021, 12:38 PM
dmbaturin renamed this task from XML: router-advert, bgp: multiple different validators cause error message to pop up even if syntax is valid to validate-value prints error messages from validators that fail even if overall validation succeeds.Feb 18 2021, 12:43 PM
dmbaturin merged a task: T3321: Bgp not possible to use internal|external remote as.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin added subscribers: SrividyaA, rherold, Unknown Object (User) and 2 others.
c-po mentioned this in T3406: tunnel: interface no longer supports specifying encaplimit none - or migrator is missing.Mar 13 2021, 8:21 PM
c-po mentioned this in T3418: BGP: system wide known interface can not be used as neighbor.Mar 21 2021, 4:33 PM
c-po added a comment.Apr 15 2021, 2:13 PM

That would also good to get this working:

https://github.com/vyos/vyatta-cfg-quagga/blob/current/templates/policy/access-list6/node.def#L7-L12

c-po added a comment.Apr 15 2021, 2:28 PM

Some notes from past meetings.

XML - current implementation:

<constraint>
  <validator name="numeric" argument="--range 1-65535"/>
</constraint>

XML - new implementation:

<constraint>
  .. validator node 1 ...
  <errorMessage>This is bad</errorMessage>
</constraint>
<constraint>
  .. validator node 2 ...
  <errorMessage>This is bad</errorMessage>
</constraint>

Only once <validator> should be supported per <constraint>

<constraintGroup>
  .. validator node 1 ...
  .. validator node 2 ...
  <errorMessage>This is bad</errorMessage>
</constraintGroup>

All constraints in <constraint> are run as logical OR, all validators under the <constraintGroup> node are run with a logical AND.

Having both constraint and constraintGroup will OR both together

jestabro subscribed.May 23 2021, 8:09 PM

Opening a new task for the issue described in the last comment, above. The original problem re. error messages was resolved in vyos-utils 68d1b283 .

jestabro mentioned this in T3574: Add constraintGroup for combining validators with logical AND.May 23 2021, 8:26 PM
dmbaturin closed this task as Resolved.Jul 29 2021, 12:52 PM
dmbaturin added a project: test.
dmbaturin edited a custom field.
dmbaturin reopened this task as Open.Jul 29 2021, 2:09 PM
jestabro added a project: VyOS 1.4 Sagitta.Aug 5 2021, 2:55 PM
jestabro removed a project: VyOS 1.4 Sagitta.
jestabro closed this task as Resolved.Aug 19 2021, 3:29 PM
erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:35 PM
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed test, VyOS 1.3 Equuleus.Sep 5 2021, 7:06 AM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0-epa1) board.Sep 5 2021, 4:08 PM
jestabro mentioned this in T3980: vrrp transition-script validator makes warning fatal and also causes a python NameError exception.Nov 12 2021, 7:20 PM