Page MenuHomeVyOS Platform
Create Task
Maniphest T3161

Consider removing ConfigLoad.pm
Closed, ResolvedPublic
Actions

Description

In the context of T1398, one should consider removing all references to XorpConfigParser, except for the still needed references in

vyatta_net_name
vyatta_interface_rescan

The residual reference is in

ConfigLoad.pm

called by

vyatta-cfg/scripts/vyatta-config-loader.pl
vyatta-cfg/scripts/vyatta-boot-config-loader

which have been replaced by

vyos-load-config.py
vyos-boot-config-loader.py

respectively, and

vyatta-cfg/scripts/vyatta-config-loader.pl

which is only used by

vyatta-cfg-system/etc/init.d/ec2-vyos-init

and should be considered for replacement or removal, if no longer used (needs to be checked). These changes would add to the simplification offered by T1398, and this task is for the above assessment.

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Related Objects
Search...

Event Timeline

jestabro created this task.Dec 29 2020, 6:09 PM
jestabro created this object in space S1 VyOS Public.
jestabro added a parent task: T1398: Remove vyatta-config-migrate package.
jestabro updated the task description. (Show Details)Dec 29 2020, 6:34 PM
jestabro updated the task description. (Show Details)Dec 29 2020, 6:58 PM
jestabro added a comment.Dec 29 2020, 10:07 PM

Taras confirms that the functionality of

vyatta-cfg-system/etc/init.d/ec2-vyos-init

is replaced by that of cloud-init tools, so this legacy invocation will be removed, allowing for the removal of ConfigLoad.pm, since the other scripts have already been rewritten.

pasik added a subscriber: pasik.Dec 30 2020, 7:28 AM
jestabro changed the task status from Open to Needs testing.Dec 30 2020, 7:02 PM

Changes in branches here:
https://github.com/vyos/vyatta-cfg/compare/current...jestabro:T3161
https://github.com/vyos/vyatta-cfg-system/compare/current...jestabro:T3161
https://github.com/vyos/vyatta-wanloadbalance/compare/current...jestabro:T3161
This will need reasonable testing before commit, although all pieces had previously been implemented

jestabro triaged this task as Normal priority.Dec 30 2020, 7:09 PM
jestabro mentioned this in T1398: Remove vyatta-config-migrate package.
jestabro added a subscriber: c-po.EditedJan 4 2021, 12:19 AM

@c-po has also tested an iso from the above branches, notably testing a vyatta-wanloadbalance configuration. It had been presumed that the listed dependency of vyatta-wanloadbalance on vyatta-config-migrate was a legacy error, as there were no explicit dependencies, but it required a sanity check. I will merge via PR's, in order to better track the changes over the 3 required packages.

jestabro closed this task as Resolved.Jan 5 2021, 1:42 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 11:44 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.