Page MenuHomeVyOS Platform

Metatask: rewrite flow-accounting to XML and Python
Closed, ResolvedPublicFEATURE REQUEST

Description

As many other tasks are indirectly related to this one (in an example, some bugs can be fixed during the re-implementation) I am creating this one task for proper tracking.

Short description: outdated vyatta-netflow package should be fully removed and replaced by relative parts of vyos-1x.

Details

Version
-
Is it a breaking change?
Behavior change
Issue type
Internal change (not visible to end users)

Event Timeline

zsdc claimed this task.

I did some work porting vyatta-netflow to new vyos model

https://github.com/elbuit/vyos-ports/tree/master/flow-accounting

flow-accounting.xml
and conf mode (unfinished)
system_flow-accounting.py

I'm just learning how new vyos model works and I thought that porting a package would be a good idea.

Let me know if you want help to port it.

Thanks, @elbuit !
We have prepared PR with full functionality: https://github.com/vyos/vyos-1x/pull/187
It would be great if you will join us and help to test it, find all bugs and fix them. :)

Wow, you did it!!!
I’ll do some tests
But I don’t know to test on a current vyos build so I’ll have to wait until the PR are accepted.
I hope it will accepted asap.

@zsdc is thwre a second PR removing the old implementation?

zsdc changed the task status from Open to In progress.Dec 19 2019, 5:23 AM

@c-po, there is also third PR in vyos-buid: https://github.com/vyos/vyos-build/pull/69

I added the kernel netflow module to my pull request a while back - collects and forwards flows to a destination defined in the module parameter set at load-time.
If we want to actually process flows on-system, there's a bunch of modern tooling for that; but in terms of just aggregation and export in canonical format, the kernel module is the best way to go IMO due to the fact that it works at the same tier as the network code itself (ring0).

erkin set Issue type to Internal change (not visible to end users).Aug 31 2021, 6:04 PM