Page MenuHomeVyOS Platform

marekm (Marek Michałkiewicz)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2020, 1:26 PM (187 w, 5 d)

Recent Activity

Thu, Mar 21

marekm added a project to T6154: Installer should ask for password twice: VyOS 1.4 Sagitta (1.4.0-epa2).
Thu, Mar 21, 9:07 PM · VyOS 1.4 Sagitta (1.4.0-epa2)
marekm created T6154: Installer should ask for password twice.
Thu, Mar 21, 9:06 PM · VyOS 1.4 Sagitta (1.4.0-epa2)
marekm changed Difficulty level from unknown to easy on T6153: Installer offers RAID-1 without excluding the USB install media.
Thu, Mar 21, 8:32 PM · VyOS 1.4 Sagitta
marekm created T6153: Installer offers RAID-1 without excluding the USB install media.
Thu, Mar 21, 8:28 PM · VyOS 1.4 Sagitta

May 8 2023

marekm created T5211: route-map allows both IPv4 and IPv6 in one rule which never match.
May 8 2023, 4:54 PM

Feb 27 2023

marekm added a comment to T4600: Closing IPV6CP by client closes PPPoE link completely, even if IPv6 is optional.

As a temporary workaround, I use the script below. For some reason /etc/rc.local no longer runs automatically on VyOS 1.3.2, so I run it manually after each reboot for now. Until it is run, Phicomm routers keep disconnecting due to failed IPV6CP negotiation incorrectly triggering complete PPPoE session termination. I have two PPPoE servers at different locations for redundancy, both rebooting at the same time is very unlikely, so I can live with it for now.

Feb 27 2023, 3:38 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta

Aug 8 2022

marekm added a comment to T4600: Closing IPV6CP by client closes PPPoE link completely, even if IPv6 is optional.

See also https://github.com/accel-ppp/accel-ppp/issues/57
Testing this patch, PPPoE session with the Phicomm router now stays up, the missing part after "else" is to remove IPv6 configuration from ppp interface (not sure how to do it properly).

diff
diff --git a/accel-pppd/ppp/ppp_ipv6cp.c b/accel-pppd/ppp/ppp_ipv6cp.c
index 1194b31..2bac31b 100644
--- a/accel-pppd/ppp/ppp_ipv6cp.c
+++ b/accel-pppd/ppp/ppp_ipv6cp.c
@@ -738,7 +738,10 @@ static void ipv6cp_recv(struct ppp_handler_t*h)
                        if (conf_ppp_verbose)
                                log_ppp_info2("recv [IPV6CP TermReq id=%x]\n", hdr->id);
                        ppp_fsm_recv_term_req(&ipv6cp->fsm);
-                       ap_session_terminate(&ipv6cp->ppp->ses, TERM_USER_REQUEST, 0);
+                       if (conf_ipv6 == IPV6_REQUIRE)
+                               ap_session_terminate(&ipv6cp->ppp->ses, TERM_USER_REQUEST, 0);
+                       else
+                               ppp_layer_passive(ipv6cp->ppp, &ipv6cp->ld);
                        break;
                case TERMACK:
                        if (conf_ppp_verbose)
Aug 8 2022, 10:01 AM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta

Aug 7 2022

marekm added a comment to T4600: Closing IPV6CP by client closes PPPoE link completely, even if IPv6 is optional.

Log messages - http://91.224.224.43/phicomm/phicomm6.log
PPPoE server config:

Aug 7 2022, 6:24 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta
marekm created T4600: Closing IPV6CP by client closes PPPoE link completely, even if IPv6 is optional.
Aug 7 2022, 3:21 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta

Jul 4 2022

marekm added a comment to T4456: NTP client in VRF tries to bind to interfaces outside VRF, logs many messages.

@marekm Did you set a proper listen to address for it?

set system ntp listen-address x.x.x.x
Jul 4 2022, 9:23 AM · VyOS 1.3 Equuleus (1.3.2), VyOS 1.4 Sagitta

Jun 2 2022

marekm created T4456: NTP client in VRF tries to bind to interfaces outside VRF, logs many messages.
Jun 2 2022, 3:30 PM · VyOS 1.3 Equuleus (1.3.2), VyOS 1.4 Sagitta

Jun 1 2022

marekm updated the task description for T4453: dhclient fails to renew DHCP lease with VRF.
Jun 1 2022, 3:39 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta
marekm created T4453: dhclient fails to renew DHCP lease with VRF.
Jun 1 2022, 8:38 AM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta

Oct 14 2020

marekm added a comment to T2060: source-validation will be configured at different locations and could lead to massive confusion.

Just my thoughts - there are situations where rp_filter is not sufficient, and it was not clear to me how to do this cleanly with the zone firewall, so I ended up hacking a few iptables commands in rc.local instead.

Oct 14 2020, 6:59 PM · VyOS 1.3 Equuleus (1.3.6), VyOS-1.2.0-GA

Oct 2 2020

marekm added a comment to T2829: PPPoE server: mppe setting is implemented as node instead of leafNode.
In T2829#73944, @c-po wrote:

There can not be a config migrator, thus the setting will be changed to "prefer" (default) which will not break any client implementations

Oct 2 2020, 2:16 AM · VyOS 1.3 Equuleus (1.3.0), VyOS 1.2 Crux (VyOS 1.2.6)

Sep 9 2020

marekm triaged T2869: Intel ethernet driver defaults sub-optimal as Wishlist priority.
Sep 9 2020, 10:00 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.2 Crux (VyOS 1.2.9), test, VyOS 1.4 Sagitta

Aug 31 2020

marekm added a comment to T2820: BGP crash in if_destroy_via_zapi.

Even with customers routes redistributed by OSPF instead of iBGP, it has just crashed again:

Aug 31 2020, 2:28 PM · VyOS 1.2 Crux
marekm added a comment to T2820: BGP crash in if_destroy_via_zapi.

I tried unit-cache earlier but it seems to have issues too - I've seen duplicate routes if the same client (all have static IP assigned by RADIUS based on username) connects to a different PPPoE server and the old route is not removed, as if the cached (not removed) PPPoE interfaces were not seen as removed in FRR. But I haven't investigated this in more detail as it's a production setup, can't experiment too much on live customers.
I'm considering if I could go back to redistributing PPPoE customers /32 routes in OSPF instead of iBGP - it has been that way for a few years (using MikroTik, before moving to VyOS), but I've recently changed it following "BGP Best Current Practices" http://www.bgp4all.com.au/pfs/_media/workshops/05-bgp-bcp.pdf which recommends using OSPF only for infrastructure, not customers - seems logical to me as BGP was designed for much larger routing tables (all of the Internet), but perhaps OSPF is still good enough for just a few hundreds of customers.

Aug 31 2020, 9:00 AM · VyOS 1.2 Crux

Aug 30 2020

marekm added a comment to T2820: BGP crash in if_destroy_via_zapi.

I've just had two different routers (one bare metal and one VM) crash roughly at the same time, triggered by many PPPoE sessions disconnecting at the same time due to a short power failure (routers itself had power all the time, but power was interrupted for about a minute to a switch on the network between the routers and PPPoE clients). Stack traces are very similar (absolute addresses differ, but the same functions and offsets in them). And again, each time watchfrr restarted bgpd but it was not working until reboot. No problems so far with two other BGP routers running a similar configu but without any dynamic interfaces (only OSPF and BGP, no PPPoE servers).

Aug 30 2020, 1:44 PM · VyOS 1.2 Crux

Aug 28 2020

marekm added a comment to T2820: BGP crash in if_destroy_via_zapi.
Aug 28 2020, 10:10 AM · VyOS 1.2 Crux

Aug 27 2020

marekm changed Version from 1.2.5 to 1.2.6-epa1 on T2820: BGP crash in if_destroy_via_zapi.
Aug 27 2020, 6:21 PM · VyOS 1.2 Crux
marekm added a comment to T2820: BGP crash in if_destroy_via_zapi.

It crashed again after 5 days in 1.2.6-epa1, in the same function, also when a dynamic PPPoE interface was deleted.
It happens less frequently after the former customers who repeatedly failed authentication have been physically disconnected.
Again, BGP no longer works after watchfrr has restarted the bgpd process. All works again after reboot.

Aug 27 2020, 6:20 PM · VyOS 1.2 Crux

Aug 25 2020

marekm updated the task description for T2825: Support for x32 user space ABI (32-bit pointers) on x86-64 arch.
Aug 25 2020, 9:09 AM · VyOS 2.0.x
marekm changed Difficulty level from unknown to hard on T2825: Support for x32 user space ABI (32-bit pointers) on x86-64 arch.
Aug 25 2020, 8:53 AM · VyOS 2.0.x
marekm created T2825: Support for x32 user space ABI (32-bit pointers) on x86-64 arch.
Aug 25 2020, 8:50 AM · VyOS 2.0.x

Aug 22 2020

marekm added a comment to T2820: BGP crash in if_destroy_via_zapi.

Maybe related - https://github.com/FRRouting/frr/issues/6439

Aug 22 2020, 2:50 PM · VyOS 1.2 Crux
marekm created T2820: BGP crash in if_destroy_via_zapi.
Aug 22 2020, 2:21 PM · VyOS 1.2 Crux