If in crux this was just a option string passed to the openvpn process,
quoting or escaping could be used to pass a parameter with '--' to an
openvpn option. I need to have a good long look at how Crux did this and
have some real life examples. For example: openvpn-option '--mssfix --up
"/some/command --param1 --param2"' (I'm not sure if this would've worked
on Crux, the quoting is probably wrong, and the up option parameter too,
but my point remains that this could've been a valid option syntax)
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 26 2020
Apr 26 2020
thomas-mangin added a comment to T2379: DHCPv6 address for interface deletion triggers a script error.
thomas-mangin closed T2350: Interface geneve conf-mode error, a subtask of T2353: Interface [conf_mode] errors parent task, as Resolved.
I agree but it will be quite some work ... I would happy to work on this as it would remove my of my issues with calling "cmd()" for network interface setting.
thomas-mangin awarded T2363: Use pyroute2 instead of calling 'ip' a Like token.
@elbandi how should this approach fix the error on image upgrade?
Just call the multiple options other name (like 'option'), and admin can modify they config if they want. no need a IM migrate script.
And leave the openvpn-option for raw option, if someone want to make a magic things in openvpn.
(like, in dhcp server, static mapping has option tagnode for "Host-specific settings" and static-mapping-parameters for raw hacking :)
Crux probably passed this as a string of options to the command line or
split it into multiple options. We need to add a parser to split the
options by '--', hopefully this won't break any options which should
include -- in one line.
@elbandi sure that I used as workaround.
vyos@vyos:~$ reboot cancel Reboot or poweroff is not scheduled
sould rewrite to multioption:
c-po closed T2386: salt: upgrade to 2019.2 packages, a subtask of T2382: salt-minion: Throws KeyError on commit, as Resolved.
c-po closed T2385: salt-minion: improve completion helpers, a subtask of T2382: salt-minion: Throws KeyError on commit, as Resolved.
c-po closed T2384: salt-minion: log to syslog and remove custom logging option, a subtask of T2382: salt-minion: Throws KeyError on commit, as Resolved.
- rename hash_type -> hash
- rename mine_interval -> interval
c-po changed the status of T2384: salt-minion: log to syslog and remove custom logging option, a subtask of T2382: salt-minion: Throws KeyError on commit, from Open to In progress.
c-po changed the status of T2384: salt-minion: log to syslog and remove custom logging option from Open to In progress.
Unknown Object (User) closed T1220: Show transceiver information from plugin modules, e.g SFP+, QSFP as Unknown Status.
Phabricator didn't get patches without task number, but this already in rolling
https://github.com/vyos/vyatta-op/commit/8dd886c9542cefe09d5a722307e0acbbf41ee9b8
I propose to backport this into crux.
Bug introduced in https://github.com/vyos/vyos-1x/commit/6ae6c5b
@jjakob as you seem to be the OpenVPN pro - you mind taking a look?
Apr 25 2020
Apr 25 2020
thomas-mangin added a comment to T2241: Changing settings on an interface causes it to fall out of bridge.
@jjakob if you enable debugging and record what is happening to the interface when it drops would be useful.
@syncer Re-opening this. Had the first exact same incident on a different router with an IPv6 BGP session on a RJ45 connection, so that would rule out any issues with the Intel X710 card in relation to this issue.
I'll try out the latest code then. But on 0421 with vyos-1x from 04-23
15:11 the issue is still there. I had most of the fix ready, it re-added
the interface back to the bridge it is supposed to be in after applying
all settings. I've thought about if this could be some function/method of
ifconfig, but I don't think it's necessary or how it would be
implemented. If the issue is still there, I'll open a PR. Then if there
is a bigger need to add this to ifconfig you can do it later.
thomas-mangin added a comment to T2241: Changing settings on an interface causes it to fall out of bridge.
For clarity, I do not believe the rewrite in the parent task is the root of the issue, as the behaviour on configuration was not changed. The code was restructured but the action logic remained the same. The same commands/actions will be run now as were run before the patchset. If something changed it will be in the conf mode interface code and not ifconfig AFAICS
thomas-mangin added a comment to T2241: Changing settings on an interface causes it to fall out of bridge.
Yes the code always does down / up. It is something @cpo and I discussed and it was deemed safer when performing changes. There could be a way to indicate that a change occur which should cause a trigger in another section. Something all sections should run on every change. This would be a major design change as we would not anymore apply everything, would need to decide what part of the change trigger this update process and implement a new section and make sure it is run !
These two days I will try to simulate the failure in the network simulator.
Should be fixed within parent task
Unknown Object (User) created Configuration Mode Templates.
Apr 24 2020
Apr 24 2020
jjakob changed the status of T2241: Changing settings on an interface causes it to fall out of bridge from Open to In progress.
@jjakob No, it's not logged in the journal either:
set firewall all-ping 'enable' set firewall broadcast-ping 'enable' set firewall config-trap 'disable' set firewall ipv6-receive-redirects 'enable' set firewall ipv6-src-route 'enable' set firewall ip-src-route 'enable' set firewall log-martians 'enable' set firewall name wan default-action 'drop' set firewall name wan rule 1 action 'accept' set firewall name wan rule 1 state established 'enable' set firewall name wan rule 1 state related 'enable' set firewall name wan-local default-action 'drop' set firewall name wan-local rule 1 action 'accept' set firewall name wan-local rule 1 state established 'enable' set firewall name wan-local rule 1 state related 'enable' set firewall name wan-local rule 2 action 'accept' set firewall name wan-local rule 2 icmp type-name 'echo-request' set firewall name wan-local rule 2 protocol 'icmp' set firewall name wan-local rule 2 state new 'enable' set firewall name wan-local rule 3 action 'drop' set firewall name wan-local rule 3 destination port '22' set firewall name wan-local rule 3 protocol 'tcp' set firewall name wan-local rule 3 recent count '4' set firewall name wan-local rule 3 recent time '60' set firewall name wan-local rule 3 state new 'enable' set firewall name wan-local rule 4 action 'accept' set firewall name wan-local rule 4 protocol 'tcp' set firewall name wan-local rule 4 state new 'enable' set firewall options interface pppoe0 adjust-mss '1452' set firewall options interface pppoe0 adjust-mss6 '1280' set firewall receive-redirects 'disable' set firewall send-redirects 'enable' set firewall source-validation 'disable' set firewall state-policy established action 'accept' set firewall state-policy established log enable set firewall state-policy invalid action 'accept' set firewall state-policy invalid log enable set firewall state-policy related action 'accept' set firewall state-policy related log enable set firewall syn-cookies 'enable' set firewall twa-hazards-protection 'disable' set interfaces bridge br1 address '192.168.0.1/24' set interfaces bridge br1 address 'fc00:470:f1cd::1/64' set interfaces bridge br1 description 'lan 0' set interfaces bridge br1 dhcpv6-options temporary set interfaces bridge br1 ipv6 address autoconf set interfaces bridge br1 ipv6 address eui64 'fc00:470:f1cd::/64' set interfaces bridge br1 ipv6 dup-addr-detect-transmits '1' set interfaces bridge br1 member interface eth1.1 set interfaces bridge br1 member interface eth2 set interfaces bridge br1 stp set interfaces bridge br2 address '192.168.101.1/24' set interfaces bridge br2 address 'fc00:470:f1cd:101::1/64' set interfaces bridge br2 description 'lan 101' set interfaces bridge br2 dhcpv6-options temporary set interfaces bridge br2 dhcpv6-options temporary set interfaces bridge br2 ipv6 address autoconf set interfaces bridge br2 ipv6 address eui64 'fc00:470:f1cd:101::/64' set interfaces bridge br2 ipv6 dup-addr-detect-transmits '1' set interfaces bridge br2 member interface eth0 set interfaces bridge br2 member interface eth1.2 set interfaces bridge br2 member interface eth3 set interfaces bridge br2 member interface eth4 set interfaces bridge br2 stp set interfaces ethernet eth0 description 'LAN' set interfaces ethernet eth0 hw-id '00:98:2b:f8:3f:11' set interfaces ethernet eth0 ipv6 address set interfaces ethernet eth0 ipv6 dup-addr-detect-transmits '1' set interfaces ethernet eth1 description 'Trunk' set interfaces ethernet eth1 hw-id '00:98:2b:f8:3f:12' set interfaces ethernet eth1 vif 1 description 'vlan 1 of eth1' set interfaces ethernet eth1 vif 2 description 'vlan 2 of eth1' set interfaces ethernet eth2 description 'LAN' set interfaces ethernet eth2 hw-id '00:98:2b:f8:3f:13' set interfaces ethernet eth3 description 'LAN' set interfaces ethernet eth3 hw-id '00:98:2b:f8:3f:14' set interfaces ethernet eth4 description 'LAN' set interfaces ethernet eth4 hw-id '00:98:2b:f8:3f:15' set interfaces ethernet eth5 description 'WAN' set interfaces ethernet eth5 disable-flow-control set interfaces ethernet eth5 firewall in name 'wan' set interfaces ethernet eth5 firewall local name 'wan-local' set interfaces ethernet eth5 hw-id '00:98:2b:f8:3f:16' set interfaces pppoe pppoe0 authentication password 'user' set interfaces pppoe pppoe0 authentication user 'passwd' set interfaces pppoe pppoe0 default-route 'auto' set interfaces pppoe pppoe0 description 'ISP' set interfaces pppoe pppoe0 ipv6 address autoconf set interfaces pppoe pppoe0 ipv6 enable set interfaces pppoe pppoe0 mtu '1492' set interfaces pppoe pppoe0 source-interface 'eth5' set nat nptv6 rule 2 description 'IPv6 NPT' set nat nptv6 rule 2 outbound-interface 'pppoe0' set nat nptv6 rule 2 source prefix 'fc00:470:f1cd::/48' set nat nptv6 rule 2 translation prefix '240e:fc:7d:64b9::/64' set nat source rule 1 description 'PUBLIC' set nat source rule 1 log 'enable' set nat source rule 1 outbound-interface 'pppoe0' set nat source rule 1 protocol 'all' set nat source rule 1 source address '0.0.0.0/0' set nat source rule 1 translation address 'masquerade' set protocols static interface-route 0.0.0.0/0 next-hop-interface pppoe0 set protocols static interface-route6 ::/0 next-hop-interface pppoe0 set protocols static table 150 interface-route 0.0.0.0/0 next-hop-interface pppoe0 set protocols static table 150 interface-route6 ::/0 next-hop-interface pppoe0 set service dhcp-server shared-network-name pri101 description 'DHCP 101' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 default-router '192.168.101.1' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 dns-server '192.168.0.254' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 dns-server '192.168.101.1' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 dns-server '192.168.0.1' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 dns-server '192.168.0.1' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 lease '86400' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 ntp-server '192.168.101.1' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 range 0 start '192.168.101.8' set service dhcp-server shared-network-name pri101 subnet 192.168.101.0/24 range 0 stop '192.168.101.254' set service dhcpv6-server preference '0' set service dhcpv6-server shared-network-name pri101 subnet fc00:470:f1cd:101::/64 address-range start fc00:470:f1cd:101::8 stop 'fc00:470:f1cd:101:ffff:ffff:ffff:ffff' set service dhcpv6-server shared-network-name pri101 subnet fc00:470:f1cd:101::/64 name-server 'fc00:470:f1cd::ff00' set service dhcpv6-server shared-network-name pri101 subnet fc00:470:f1cd:101::/64 name-server 'fc00:470:f1cd::1' set service dhcpv6-server shared-network-name pri101 subnet fc00:470:f1cd:101::/64 name-server 'fc00:470:f1cd:101::1' set service dns forwarding allow-from '192.168.0.0/16' set service dns forwarding allow-from '2001:470:f1cd::/48' set service dns forwarding cache-size '1024' set service dns forwarding domain pve. server '192.168.0.47' set service dns forwarding domain pve. server '2001:470:f1cd::47' set service dns forwarding listen-address '0.0.0.0' set service dns forwarding listen-address '::' set service dns forwarding name-server '2001:470:f1cd::ff00' set service dns forwarding name-server '192.168.0.254' set service dns forwarding name-server '202.96.134.33' set service dns forwarding name-server '202.96.128.86' set service dns forwarding name-server '114.114.114.114' set service dns forwarding name-server '1.1.1.1' set service dns forwarding name-server '1.0.0.1' set service dns forwarding system set service https virtual-host vhost0 listen-address '*' set service https virtual-host vhost0 server-name '192.168.0.1' set service mdns repeater interface 'br1' set service mdns repeater interface 'br2' set service router-advert interface br1 set service router-advert interface br2 name-server 'fc00:410:f1cd:101::1' set service ssh listen-address '0.0.0.0' set system acceleration set system config-management commit-revisions '100' set system console device ttyS0 speed '115200' set system domain-name 'router' set system host-name 'vyos' set system ip arp table-size '2048' set system ip multipath layer4-hashing set system ipv6 multipath layer4-hashing set system ipv6 neighbor table-size '2048' set system ipv6 strict-dad set system login user vyos authentication encrypted-password '$6$UaXQViDvJ.Hr$85U/9Q5d/tc9hdtrnntMVgrztOCext..OJCHaJYZUo82GAdD95lchvSjI3vCZJTNte7cIAs87YctYlXODGXAz1' set system login user vyos authentication plaintext-password '' set system name-server '192.168.0.1' set system ntp allow-clients address '192.168.0.0/16' set system ntp allow-clients address 'fc00:470:f1cd::/48' set system ntp listen-address '::' set system ntp listen-address '0.0.0.0' set system ntp server 0.debian.pool.ntp.org set system ntp server 1.debian.pool.ntp.org set system ntp server 2.debian.pool.ntp.org set system ntp server 3.debian.pool.ntp.org set system sysctl custom net.ipv4.conf.all.rp_filter value '0' set system sysctl custom net.ipv4.conf.default.rp_filter value '0' set system sysctl custom net.ipv4.conf.eth0.rp_filter value '0' set system sysctl custom net.ipv6.conf.all.accept_ra value '2' set system sysctl custom net.ipv6.conf.all.forwarding value '1' set system syslog global facility all level 'info' set system syslog global facility protocols level 'debug' set system time-zone 'Asia/Shanghai'
Please always include a copy of your configurationw which would make labbing much easier
GitHub <noreply@github.com> committed rVYOSONEX35dc9d35c5d9: Merge pull request #376 from thomas-mangin/T2377 (authored by c-po).
It seems that IPv6 is not only the case even in IPv4, but I don't understand that this happens. I remember that 1.2-rolling-20191203 has no such problem. If so, it shouldn't be the problem of my local ISP network. Moreover, this problem also exists in the PPPoE of IPv4. It's more doubtful that there may be a bug in the PPPoE of vyos. Although the bug may occur in a specific environment?
I think it's strange, but in fact, I'll try to see it in GNS tomorrow!
@jack9603301 unfortunately I can not reproduce this behavior on my PPPoE link - it runs stable with the latest rolling versions and I have 0 disconnects - neither in a LAB with VyOS PPPoE server not Deutsche Telekom or M-Net links.
@jjakob this is the wrong phabricator entry to discuss it but I got your point ;-)
This is correct.