Page MenuHomeVyOS Platform
Create Task
Maniphest T2382

salt-minion: Throws KeyError on commit
Closed, ResolvedPublicBUG
Actions

Description

set service salt-minion master 1.1.1.1
set service salt-minion id foo
commit
[ service salt-minion ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/salt-minion.py", line 131, in <module>
    generate(c)
  File "/usr/libexec/vyos/conf_mode/salt-minion.py", line 84, in generate
    uid = getpwnam(salt['user']).pw_uid
KeyError: "getpwnam(): name not found: 'minion'"

[[service salt-minion]] failed
Commit failed

Details

Version
1.3-rolling-202004201924
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

c-po created this task.Apr 26 2020, 7:49 AM
c-po added a comment.Apr 26 2020, 7:52 AM

Bug introduced in https://github.com/vyos/vyos-1x/commit/6ae6c5b

c-po changed the task status from Open to In progress.Apr 26 2020, 8:27 AM
c-po claimed this task.
c-po edited a custom field.
c-po changed the status of subtask T2384: salt-minion: log to syslog and remove custom logging option from Open to In progress.Apr 26 2020, 9:30 AM
c-po closed subtask T2384: salt-minion: log to syslog and remove custom logging option as Resolved.Apr 26 2020, 9:33 AM
c-po closed subtask T2385: salt-minion: improve completion helpers as Resolved.
c-po mentioned this in rVYOSONEX817ffb3f09b3: salt: T2382: add missing dependency on salt-minion.Apr 26 2020, 9:34 AM
c-po mentioned this in rVYOSONEXad39362fb0e5: salt: T2382: XML: add proper valueHelp and validators for master.
c-po mentioned this in rVYOSONEXe47502b6de53: salt: T2382: add missing verify().
c-po mentioned this in rVYOSONEXd98a0d596790: salt: T2382: XML: run as user nobody.
c-po mentioned this in rVYOSONEX2102c7c318ef: salt: T2382: id and master nodes are mandatory - use in verify().
c-po mentioned this in rVYOSONEX07f2b18a8a3d: salt: T2382: migrate get_config() to list items.
c-po mentioned this in rVYOSONEX3027a904c96b: salt: T2382: ease config generation.
c-po mentioned this in rVYOSONEX529cf467098d: Revert "salt: T2382: id and master nodes are mandatory - use in verify()".
c-po mentioned this in rVYOSONEXb014bfaadc41: Merge branch 'salt' of github.com:c-po/vyos-1x into current.
c-po closed subtask T2386: salt: upgrade to 2019.2 packages as Resolved.Apr 26 2020, 9:38 AM
c-po closed this task as Resolved.Apr 26 2020, 10:00 AM
c-po mentioned this in rVYOSONEX8fd8a4cb3226: salt: T2382: run as user minion.Apr 26 2020, 10:00 AM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 4:17 PM
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 6:33 AM
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:02 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.