It will come in 2 parts, the ppp server as a package first and then the rewrite for its config, hard to estimate the time it will need, let me first package accel-ppp.

@syncer I discovered a possible issue, accel-ppp is incompatible with the ip_gre driver, so using accel-ppp means you can't have gre tunnels anymore and vice versa. I'm not sure if accel-ppp is a good idea to integrate into vyos. Shall I continue with the packages or should we check if we can find anything compatible which doesn't interfere with router stuff. Not having gre is in my opinion a very significant issue.

@hagbard not having GRE on PPPoE server not a problem
we still need to see how we handle this and bunch of other issues
but we definitely need BRAS functionality

@hagbard if you want you can do cli part and we can ask do other stuff @dmbaturin and/or @UnicronNL
it's up to you
thanks!

@syncer It doesn't really matter to me, I was just concerned that if you have pppoe-server running, you can't use gre tunnels (the kernel module can't be loaded anymore).

@hagbard yea, it's more about share work and involves other people in collaboration :)
You also may want to join accel-ppp telegram channel tg://join?invite=DS6swRC3DvEWdNijTqaaeA

All right, back here.

@syncer how do you get https://github.com/hagbard-01/vyos-accel-ppp into your repo?
It builds the accel-ppp package, which I then later will need for the cli stuff.

will add you to github org
move repo there, and for it back to your account

Sweet, thx.

Here it is:
https://github.com/vyos/vyos-accel-ppp

I'm going to keep this task still open till the end of the week to catch eventual bugs.

the flag accept-any-service is interest to implement, to accept any service name from client side

Hi @andersonpcazm,

can you please let me know from where you have that flag? It dosn't exist in the accel-ppp documentation.

i found using the command man accel-ppp
you can to find it in this link
https://github.com/xebd/accel-ppp/blob/master/accel-pppd/accel-ppp.conf.5
when use value 1, in flag accept-any-service, the server will accept any service name in client side, generally is in blank in client side.

That is already the case if you don't configure a SN on the server side. So I'm not sure if this setting is not more of a pain instead of a help.

it's not so important, just a suggestion, is better concentrate in functions of extreme importance, as ipoe

will implement the shaper for bandwidth control? or should I configure manually?

Yes it will be implemented as soon as it turns out that the switch from the old implementation was successful. We have seen kernel crashes every now and then with the shaper enabled, so I would be keen to know if that happens to you as well to investigate the root cause.

I tested the shaper, but it seems to me that the Cisco-AVPair library is missing, it may be missing from my Radius server

Edit: I am a network administrator without programming knowledge, how can I help with the development of vyos?