Page MenuHomeVyOS Platform
Create Task
Maniphest T6416

Run smoke tests before merging
Open, LowPublicFEATURE REQUEST
Actions

Description

We want to run smoke tests against proposed PR before merging it
this way we can avoid merging PRs that will break something and focus on fixing code

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenFEATURE REQUESTVijayakumarT6309 GitHub integration CodeQL root task
 OpenFEATURE REQUESTNoneT6416 Run smoke tests before merging

Event Timeline

syncer created this task.May 29 2024, 12:17 PM
pasik subscribed.May 29 2024, 12:27 PM
Viacheslav renamed this task from Run smole tests before merging to Run smoke tests before merging .May 29 2024, 1:53 PM
syncer triaged this task as Low priority.May 29 2024, 2:52 PM
Embezzle subscribed.May 29 2024, 5:36 PM
Vijayakumar added a comment.May 29 2024, 6:51 PM

For this, need to get details on our existing smoke tests.

Vijayakumar added a comment.EditedMay 30 2024, 4:19 AM

Hope we need to run this for smoke test
https://github.com/vyos/vyos-1x?tab=readme-ov-file#tests

pipenv install --dev
pipenv shell
make test
syncer added a comment.May 30 2024, 5:29 AM

no it's not
hold on with his task for now

Vijayakumar added a comment.May 30 2024, 6:33 AM

ok, sure