Page MenuHomeVyOS Platform
Create Task
Maniphest T5353

config-mgmt: normalize archive updates and commit log entries
Closed, ResolvedPublicBUG
Actions

Description

Before the introduction of vyos-save-config, there remained a mismatch in comparing archived configs (using configtree) and saved configs (using vyatta-save-config); this led to a redundancy in archived configs, compounded by unnecessary entries in the commit log itself. This became clear after the introduction of vyos-save-config and T5551. Correct the test for whether to archive and add to commit log.

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.5, vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

jestabro triaged this task as Normal priority.Jul 12 2023, 2:33 PM
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro added a parent task: T5347: Compare commit revision bug.
jestabro changed the task status from Open to In progress.Sep 5 2023, 1:15 PM
jestabro added a project: VyOS 1.5 Circinus.
jestabro added a parent task: T5551: Missing check for boot_configuration_complete raises error in vyos-save-config.py.Sep 5 2023, 6:12 PM
jestabro renamed this task from config-mgmt: unnecessary entires in commit log compared to archived configs to config-mgmt: normalize archive updates and commit log entries.Sep 5 2023, 6:35 PM
jestabro updated the task description. (Show Details)
jestabro changed Version from vyos-1.4 to vyos-1.5, vyos-1.4.
jestabro added a comment.Sep 5 2023, 8:02 PM

PR for current:
https://github.com/vyos/vyos-1x/pull/2211

jestabro changed the task status from In progress to Backport pending.Sep 6 2023, 6:28 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
jestabro added a comment.Sep 7 2023, 2:09 AM

PR for Sagitta (draft until dependency PR 2207 is merged to Sagitta):
https://github.com/vyos/vyos-1x/pull/2215

jestabro changed Difficulty level from Easy (less than an hour) to Normal (likely a few hours).Sep 7 2023, 2:20 AM
jestabro mentioned this in T5556: reboot now and poweroff does not work.Sep 7 2023, 5:53 PM
jestabro added a subtask: T5556: reboot now and poweroff does not work.Sep 8 2023, 12:57 AM

Sagitta PR updated with fix for regression in T5556.

pasik added a subscriber: pasik.Sep 8 2023, 9:41 AM
jestabro closed this task as Resolved.Sep 11 2023, 5:32 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.