Page MenuHomeVyOS Platform
Create Task
Maniphest T4880

Expose 'add/delete container image' in HTTP-API
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

This issue was suggested within a conversation in 'vyos-general-discussion' regarding configuring containers vis api/terraform:
https://vyos.slack.com/archives/C01A6CJFW1F/p1670621707955169?thread_ts=1670456965.837619&cid=C01A6CJFW1F
Related to https://phabricator.vyos.net/T4487

Two possible approaches:

  1. Include 'add/delete' in list of 'canonical' functions in op-mode, and expose in op-mode/container.py
  2. Include 'add/delete container image' in configsession.py

In either case, functions will be automatically exposed to the GraphQL API, and an endpoint can be added for the REST API.

Details

Version
vyos-1.4
Is it a breaking change?
Perfectly compatible
Issue type
Feature (new functionality)

Related Objects
Search...

StatusSubtypeAssignedTask
ResolvedFEATURE REQUESThigebuT578 Support Linux Container
ResolvedFEATURE REQUESTjestabroT4880 Expose 'add/delete container image' in HTTP-API

Event Timeline

jestabro created this task.Dec 14 2022, 3:33 PM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
Viacheslav awarded a token.Dec 14 2022, 3:42 PM
pasik subscribed.Dec 14 2022, 6:08 PM
jestabro renamed this task from Expose 'add/delete containter image' in HTTP-API to Expose 'add/delete container image' in HTTP-API.Dec 14 2022, 7:50 PM
c-po added a parent task: T578: Support Linux Container.Dec 30 2022, 8:38 PM
jestabro changed the task status from Open to In progress.Jan 9 2023, 9:48 PM

PR: https://github.com/vyos/vyos-1x/pull/1744

Restricted Repository Identity mentioned this in rVYOSONEXc86ed3df1e30: Merge pull request #1744 from jestabro/container-op-mode.Jan 10 2023, 3:24 PM
jestabro mentioned this in rVYOSONEXba4aebaaa816: container: T4880: add REST API endpoint for add/delelete/show images.Jan 10 2023, 3:24 PM
jestabro mentioned this in rVYOSONEXf440fbc9ba90: container: T4880: expose add_image/delete_image functions in op-mode.
jestabro mentioned this in rVYOSONEX2fc4f15353eb: container: T4880: include 'add'/'delete' in standard op-mode functions.
jestabro closed this task as Resolved.Jan 10 2023, 4:26 PM
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
jestabro mentioned this in rVYOSONEX2b00908524e6: container: T4880: fix name collision.Jan 11 2023, 3:02 PM
adestis mentioned this in T5785: API output of show container image broken.Nov 27 2023, 4:29 PM