Page MenuHomeVyOS Platform
Create Task
Maniphest T4354

Slave interfaces fall out from bonding during configuration change
Closed, ResolvedPublicBUG
Actions

Description

If we change the configuration for a slave interface, it falls out from a bonding.
How to reproduce:

set interfaces bonding bond0 member interface 'eth1'
set interfaces bonding bond0 member interface 'eth2'
commit
ip -d l
cat /proc/net/bonding/bond0

set interfaces ethernet eth2 description 'TEST'
commit
ip -d l
cat /proc/net/bonding/bond0

Output:

[edit]
vyos@vyos# set interfaces bonding bond0 member interface 'eth1'
[edit]
vyos@vyos# set interfaces bonding bond0 member interface 'eth2'
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# ip -d l
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 minmtu 0 maxmtu 0 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
3: eth1: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master bond0 state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 
    bond_slave state ACTIVE mii_status UP link_failure_count 0 perm_hwaddr 0c:dc:3c:17:00:01 queue_id 0 ad_aggregator_id 1 ad_actor_oper_port_state 69 ad_actor_oper_port_state_str <active,aggregating,defaulted> ad_partner_oper_port_state 1 ad_partner_oper_port_state_str <active> addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
4: eth2: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master bond0 state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:01 brd ff:ff:ff:ff:ff:ff permaddr 0c:dc:3c:17:00:02 promiscuity 0 minmtu 68 maxmtu 65535 
    bond_slave state BACKUP mii_status UP link_failure_count 0 perm_hwaddr 0c:dc:3c:17:00:02 queue_id 0 ad_aggregator_id 2 ad_actor_oper_port_state 69 ad_actor_oper_port_state_str <active,aggregating,defaulted> ad_partner_oper_port_state 1 ad_partner_oper_port_state_str <active> addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
5: eth3: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:03 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
6: bond0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 
    bond mode 802.3ad miimon 100 updelay 0 downdelay 0 peer_notify_delay 0 use_carrier 1 arp_interval 0 arp_validate none arp_all_targets any primary_reselect always fail_over_mac none xmit_hash_policy layer2 resend_igmp 1 num_grat_arp 1 all_slaves_active 0 min_links 0 lp_interval 1 packets_per_slave 1 lacp_rate slow ad_select stable ad_aggregator 1 ad_num_ports 1 ad_actor_key 0 ad_partner_key 1 ad_partner_mac 00:00:00:00:00:00 tlb_dynamic_lb 1 addrgenmode none numtxqueues 16 numrxqueues 16 gso_max_size 65536 gso_max_segs 65535 
[edit]
vyos@vyos# cat /proc/net/bonding/bond0
Ethernet Channel Bonding Driver: v5.10.110-amd64-vyos

Bonding Mode: IEEE 802.3ad Dynamic link aggregation
Transmit Hash Policy: layer2 (0)
MII Status: up
MII Polling Interval (ms): 100
Up Delay (ms): 0
Down Delay (ms): 0
Peer Notification Delay (ms): 0

802.3ad info
LACP rate: slow
Min links: 0
Aggregator selection policy (ad_select): stable

Slave Interface: eth1
MII Status: up
Speed: Unknown
Duplex: Unknown
Link Failure Count: 0
Permanent HW addr: 0c:dc:3c:17:00:01
Slave queue ID: 0
Aggregator ID: 1
Actor Churn State: monitoring
Partner Churn State: monitoring
Actor Churned Count: 0
Partner Churned Count: 0

Slave Interface: eth2
MII Status: up
Speed: Unknown
Duplex: Unknown
Link Failure Count: 0
Permanent HW addr: 0c:dc:3c:17:00:02
Slave queue ID: 0
Aggregator ID: 2
Actor Churn State: monitoring
Partner Churn State: monitoring
Actor Churned Count: 0
Partner Churned Count: 0
[edit]
vyos@vyos# 
[edit]
vyos@vyos# set interfaces ethernet eth2 description 'TEST'
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# ip -d l
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0 minmtu 0 maxmtu 0 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
3: eth1: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master bond0 state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 
    bond_slave state ACTIVE mii_status UP link_failure_count 0 perm_hwaddr 0c:dc:3c:17:00:01 queue_id 0 ad_aggregator_id 1 ad_actor_oper_port_state 69 ad_actor_oper_port_state_str <active,aggregating,defaulted> ad_partner_oper_port_state 1 ad_partner_oper_port_state_str <active> addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
4: eth2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:02 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
    alias TEST
5: eth3: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:03 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 
6: bond0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether 0c:dc:3c:17:00:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 
    bond mode 802.3ad miimon 100 updelay 0 downdelay 0 peer_notify_delay 0 use_carrier 1 arp_interval 0 arp_validate none arp_all_targets any primary_reselect always fail_over_mac none xmit_hash_policy layer2 resend_igmp 1 num_grat_arp 1 all_slaves_active 0 min_links 0 lp_interval 1 packets_per_slave 1 lacp_rate slow ad_select stable ad_aggregator 1 ad_num_ports 1 ad_actor_key 0 ad_partner_key 1 ad_partner_mac 00:00:00:00:00:00 tlb_dynamic_lb 1 addrgenmode none numtxqueues 16 numrxqueues 16 gso_max_size 65536 gso_max_segs 65535 
[edit]
vyos@vyos# cat /proc/net/bonding/bond0
Ethernet Channel Bonding Driver: v5.10.110-amd64-vyos

Bonding Mode: IEEE 802.3ad Dynamic link aggregation
Transmit Hash Policy: layer2 (0)
MII Status: up
MII Polling Interval (ms): 100
Up Delay (ms): 0
Down Delay (ms): 0
Peer Notification Delay (ms): 0

802.3ad info
LACP rate: slow
Min links: 0
Aggregator selection policy (ad_select): stable

Slave Interface: eth1
MII Status: up
Speed: Unknown
Duplex: Unknown
Link Failure Count: 0
Permanent HW addr: 0c:dc:3c:17:00:01
Slave queue ID: 0
Aggregator ID: 1
Actor Churn State: monitoring
Partner Churn State: monitoring
Actor Churned Count: 0
Partner Churned Count: 0

Details

Version
1.4-rolling-202204100814, 1.3.1-S1
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

zsdc created this task.Apr 11 2022, 7:17 PM
zsdc added a project: VyOS 1.3 Equuleus.
pasik subscribed.Apr 11 2022, 8:05 PM
Viacheslav subscribed.Apr 13 2022, 1:46 PM

For some reason is_bond_member is not in the configuration after the description
eth2 with option is_bond_member
eth3 without option is_bond_member

############## MY DEBUG START: 
{'description': 'fofof',
 'duplex': 'auto',
 'hw_id': '50:08:00:01:00:03',
 'ifname': 'eth3',
 'ip': {'arp_cache_timeout': '30'},
 'mtu': '1500',
 'speed': 'auto'}
####### MY DEBUG END #######

############## MY DEBUG START: 
{'description': 'fofof',
 'duplex': 'auto',
 'hw_id': '50:08:00:01:00:02',
 'ifname': 'eth2',
 'ip': {'arp_cache_timeout': '30'},
 'is_bond_member': {'bond0': {}},
 'mtu': '1500',
 'speed': 'auto'}
####### MY DEBUG END #######
c-po claimed this task.Apr 13 2022, 8:49 PM
Viacheslav added a comment.Apr 14 2022, 2:01 PM

smoketest https://github.com/vyos/vyos-1x/pull/1283

zsdc mentioned this in T4361: `vyos.config.exists()` does not work for nodes with multiple values.Apr 14 2022, 5:39 PM
Viacheslav added a comment.Apr 14 2022, 5:40 PM

The issue with this check
A possible original issue with the function exists as it checks the only first value

bond
  member
    - eth2
    - eth3

It returns only eth2 as a member of the bonding

Restricted Repository Identity mentioned this in rVYOSONEXc944188a7e22: Merge pull request #1283 from sever-sever/T4354.Apr 14 2022, 6:48 PM
Viacheslav mentioned this in rVYOSONEXae815d1b11a4: smoketest: T4354: Add test for uniq bonding members.Apr 14 2022, 6:48 PM
c-po added a parent task: T4361: `vyos.config.exists()` does not work for nodes with multiple values.May 6 2022, 6:53 PM
c-po added a comment.May 6 2022, 7:35 PM

1.3 fix via https://github.com/vyos/vyos-1x/pull/1318

c-po mentioned this in rVYOSONEXd903c9b43225: smoketest: T4354: Add test for uniq bonding members.May 7 2022, 8:42 AM
c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.May 7 2022, 5:12 PM
c-po closed this task as Resolved.May 7 2022, 5:33 PM
c-po triaged this task as High priority.
c-po edited projects, added VyOS 1.3 Equuleus (1.3.2); removed VyOS 1.3 Equuleus.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.2) board.
dmbaturin mentioned this in 1.3.2.Sep 5 2022, 3:14 PM
dmbaturin mentioned this in 1.3.2.Sep 15 2022, 10:42 AM