Page MenuHomeVyOS Platform
Create Task
Maniphest T3871

Resolve unexpected interface name reordering
Needs testing, NormalPublicBUG
Actions

Description

It is a recurring problem that on certain platforms ethernet interfaces will have changed associations: interface name <-> hw-id, after a reboot or upgrade. There has been active discussion regarding the problem recently, and consensus on a preliminary design to resolve the issue. This task will serve as meta-task for investigation and resolution.

An incomplete collection of related tasks:

https://phabricator.vyos.net/T291
https://phabricator.vyos.net/T577
https://phabricator.vyos.net/T1499
https://phabricator.vyos.net/T1671
https://phabricator.vyos.net/T2838

Details

Version
vyos-1.4
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

jestabro created this task.Sep 28 2021, 5:02 PM
jestabro created this object in space S1 VyOS Public.
jestabro updated the task description. (Show Details)
jestabro added a subtask: T3869: Rewrite vyatta_net_name/vyatta_interface_rescan in Python.
jestabro mentioned this in T3869: Rewrite vyatta_net_name/vyatta_interface_rescan in Python.
pasik subscribed.Sep 28 2021, 7:44 PM
jestabro closed subtask T3869: Rewrite vyatta_net_name/vyatta_interface_rescan in Python as Resolved.Sep 30 2021, 5:58 PM
jestabro mentioned this in T3876: Replace vyos-netplug with a VyOS link state monitor service.Sep 30 2021, 7:26 PM
jestabro added a subtask: T3876: Replace vyos-netplug with a VyOS link state monitor service.
remyvv subscribed.Oct 20 2021, 9:45 AM
sarthurdev subscribed.Oct 26 2021, 5:09 PM
Restricted Repository Identity mentioned this in rVYOSONEX552ab74b49a4: Merge pull request #1067 from DmitriyEshenko/current-08112021-fix-net-names.Nov 10 2021, 1:39 AM
Unknown Object (User) mentioned this in rVYOSONEXee02ca93ec7b: interface-names: T3871: Add temporary interface names to properly renaming.Nov 10 2021, 1:39 AM
jestabro mentioned this in rVYOSONEX86e498517b89: interface-names: T3871: shift index to accommodate KVM behaviour.Nov 12 2021, 2:54 PM
jestabro mentioned this in rVYOSONEX57ffa79bbde2: interface-names: T3871: 'migrate' component string syntax as needed.Nov 18 2021, 4:09 PM
Restricted Repository Identity mentioned this in rVYOSONEX93cdb6f1ca00: Merge pull request #1182 from jestabro/migrate-while-udev.Jan 20 2022, 7:44 PM
jestabro mentioned this in rVYOSONEXa41826759ae7: interface-names: T3871: use tempfile during virtual migration.Jan 20 2022, 7:44 PM
c-po added a subtask: T4171: Interface config migration error on 1.2.8 -> 1.4 upgrade.Jan 20 2022, 7:44 PM
c-po closed subtask T4171: Interface config migration error on 1.2.8 -> 1.4 upgrade as Resolved.
eronlloyd subscribed.Feb 20 2022, 11:51 AM
marvin subscribed.Apr 29 2022, 5:23 PM
daniil mentioned this in T4030: SR-IOV and interface renaming bug .Jul 18 2022, 8:38 AM
stingalleman subscribed.Aug 3 2022, 1:16 PM
syncer changed the task status from Open to In progress.Feb 2 2023, 7:38 PM
syncer triaged this task as High priority.
jestabro added a comment.Feb 2 2023, 8:01 PM

The approach in commit ee02ca93 of vyos-1x was considered a reasonable workaround for all but a few corner cases. However, the issue pointed out in

https://phabricator.vyos.net/T4966

and PR:

https://github.com/vyos/vyos-build/pull/302

re-raises the question.

syncer reassigned this task from jestabro to Viacheslav.Feb 2 2023, 9:57 PM
jestabro added a comment.Feb 3 2023, 5:49 PM

Before adopting the approach mentioned above, there was development of an alternative using pyudev within an 'interface-monitor' daemon; the following branches contain (a version of) the rebased code. It would need a few hours of attention to check the logic and add the is_persistent check from vyos-interface-rescan.py; it could use some refactoring as well.

https://github.com/vyos/vyos-1x/compare/current...jestabro:vyos-1x:interface-monitor
https://github.com/vyos/vyatta-cfg/compare/current...jestabro:vyatta-cfg:interface-monitor
https://github.com/vyos/vyos-build/compare/current...jestabro:vyos-build:interface-monitor

sarthurdev added a comment.Feb 3 2023, 9:33 PM
In T3871#141847, @jestabro wrote:

Before adopting the approach mentioned above, there was development of an alternative using pyudev within an 'interface-monitor' daemon; the following branches contain (a version of) the rebased code. It would need a few hours of attention to check the logic and add the is_persistent check from vyos-interface-rescan.py; it could use some refactoring as well.

https://github.com/vyos/vyos-1x/compare/current...jestabro:vyos-1x:interface-monitor
https://github.com/vyos/vyatta-cfg/compare/current...jestabro:vyatta-cfg:interface-monitor
https://github.com/vyos/vyos-build/compare/current...jestabro:vyos-build:interface-monitor

I think your interface-monitordaemon looks like a good long term solution to this.

jestabro added a comment.Feb 23 2023, 7:58 PM

The above repos are suitable for testing: basic tests in vm's and a Protecli device look fine. Note that the vyos-1x repo artificially disables the potential config mode reordering in order to confirm tests of vyos-interface-monitor.:
https://github.com/vyos/vyos-1x/commit/02d874e65262cbd53b413b3eef659b8e7d78bf31

It remains an open question whether the wrapper around libudev (pyudev) will satisfy all our use cases, but it a reasonable approach for testing.

Debugging info is logged if the system is booted with parameter 'vyos-interface-debug'.

The tools are in place to support hot-plugged devices, though that will be a separate round of implementation/testing, as there will again be interactions with conf_mode ifconfig/interface.py on initialization, which will need to be reconciled.

jestabro mentioned this in T2838: Ethernet device names changing, multiple hw-id being added.Mar 7 2023, 5:03 PM
syncer changed the subtype of this task from "Task" to "Bug".Jun 14 2023, 10:43 AM
stingalleman added a comment.Sep 24 2023, 4:16 PM

When will this bug be fixed? I am having a lot of issues with this.

jestabro added a comment.Sep 24 2023, 11:52 PM

@stingalleman As mentioned above (and confirmed in discussions earlier this week), we've had few if any reports of issues with the udev approach, so we would be very interested to hear details of your case.

yun subscribed.Jan 5 2024, 9:53 PM
dmbaturin merged a task: T1671: rewrite udev script logic /lib/udev/vyatta_net_name.Jan 9 2024, 3:54 PM
dmbaturin added a subscriber: hagbard.
stingalleman added a comment.Jan 10 2024, 2:03 AM
In T3871#160827, @jestabro wrote:

@stingalleman As mentioned above (and confirmed in discussions earlier this week), we've had few if any reports of issues with the udev approach, so we would be very interested to hear details of your case.

Hi,

I was doing something stupid - whoops:)

It's working like expecting.

Thanks!

jestabro lowered the priority of this task from High to Normal.Jan 10 2024, 3:31 PM

Lowering priority to normal to proceed with adding the interface-monitor daemon development, mentioned above, for 1.5.

remyvv unsubscribed.Jan 10 2024, 3:33 PM
Viacheslav changed the task status from In progress to Needs testing.Jan 19 2024, 10:06 PM
syncer edited projects, added VyOS 1.4 Sagitta (1.4.0-GA); removed VyOS 1.4 Sagitta.May 7 2024, 8:03 AM
jestabro changed the status of subtask T3876: Replace vyos-netplug with a VyOS link state monitor service from In progress to On hold.May 15 2024, 5:33 PM
vyosbot removed Viacheslav as the assignee of this task.Aug 14 2024, 6:12 AM
vyosbot added a subscriber: Viacheslav.
lucasec subscribed.Aug 16 2024, 7:02 AM

I took some time to re-test this on recent rolling releases and it seemed mostly positive.

I have a SuperMicro A2SDi-TP8F (Intel C3858) system that has 8 built-in NICs plus a PCIe expansion card I added provided one additional NIC. For some reason, the native kernel ordering decided to put the expansion card NIC in the middle of the built-in NICs e.g. eth0 (built-in), eth1 (expansion card), eth2 (built-in), ...

On 1.3 I was able to rename the interfaces to follow a more logical order. I don't remember exactly how I set it up but I'm pretty sure I did so using normal configuration commands.

On the current 1.5 rolling, I didn't have much luck renaming... "edit interfaces; rename ethernet eth8 to ethernet eth9"; commit;" would fail with an error about interface eth9 not existing.
However, if I manually patched config.boot in a text editor and rebooted the system it did respect the hw-ids and place the interfaces in my desired order during boot.
Is the ability to re-name an interface after boot something that we are intending to support?

Still overall an improvement from the early 1.4 builds which definitely didn't respect anything defined in the config file (boot time or otherwise).

dmbaturin added a project: Bugs.Sep 15 2024, 5:03 PM