Page MenuHomeVyOS Platform
Create Task
Maniphest T2180

get_config_dict should be independent of CLI edit level
Closed, ResolvedPublicBUG
Actions

Description

The recommended behaviour is that get_config_dict should:
(1) respect Config set_level
(2) be agnostic regarding CLI 'edit level'

Constraint (1) is currently satisfied if CLI editing is at the top level. Constraint (2) will require saving and resetting the environment to the top level in show_config; note that using '---show-ignore-edit' is not a solution, as it would disallow the 'path' argument to show_config/get_config_dict. With that modification to show_config, both (1) and (2) are satisfied irrespective of CLI edit level.

Details

Difficulty level
Unknown (require assessment)
Version
vyos 1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Behavior change
Issue type
Internal change (not visible to end users)

Related Objects
Search...

Event Timeline

jestabro changed the task status from Open to In progress.Mar 29 2020, 7:52 PM
jestabro triaged this task as Normal priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro added a parent task: T2168: Config edit level affecting the show_config() function.
jestabro updated the task description. (Show Details)Mar 29 2020, 8:13 PM
jestabro added a comment.Mar 29 2020, 9:38 PM

https://github.com/vyos/vyos-1x/pull/284

jestabro changed the task status from In progress to Needs testing.Mar 29 2020, 9:39 PM
jestabro changed the subtype of this task from "Task" to "Bug".Mar 30 2020, 1:23 AM
pasik added a subscriber: pasik.Mar 30 2020, 7:03 AM
dmbaturin added a subscriber: dmbaturin.Mar 30 2020, 11:57 PM

I think I agree: at commit time, user's CLI edit level is irrelevant and should have no effect on the script behaviour.

jestabro closed this task as Resolved.Mar 31 2020, 12:06 AM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Apr 5 2020, 12:35 PM
erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 7:54 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:03 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.