HomeVyOS Platform

dhcp: dhcpv6: T3316: Add `subnet-id` so leases remain mapped to entries in the…

Description

dhcp: dhcpv6: T3316: Add subnet-id so leases remain mapped to entries in the lease file (#2796)

Details

Provenance
sarthurdevAuthored on Jan 11 2024, 5:46 AM
GitHubCommitted on Jan 11 2024, 5:46 AM
Parents
rVYOSONEX7c6cb9829356: Merge pull request #2791 from sever-sever/T5918
Branches
Loading...
Tags
Loading...

Event Timeline

when migrating from pre subnet-id builds to a subnet build will cause migration failed during initial startup due to missing subnet id.

when migrating from pre subnet-id builds to a subnet build will cause migration failed during initial startup due to missing subnet id.

Are you able to provide the dhcp config that fails migration? I wasn't able to re-create any migration problem in my tests

Are you able to provide the dhcp config that fails migration? I wasn't able to re-create any migration problem in my tests

set service dhcp-server hostfile-update
set service dhcp-server shared-network-name LAN option name-server '192.168.1.1'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 lease '86400'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 option default-router '192.168.1.1'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 option domain-name 'localdomain'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 option name-server '192.168.1.1'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 range 0 start '192.168.1.9'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 range 0 stop '192.168.1.254'

same as whats in the old quickstart guide

Are you able to provide the dhcp config that fails migration? I wasn't able to re-create any migration problem in my tests

set service dhcp-server hostfile-update
set service dhcp-server shared-network-name LAN option name-server '192.168.1.1'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 lease '86400'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 option default-router '192.168.1.1'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 option domain-name 'localdomain'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 option name-server '192.168.1.1'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 range 0 start '192.168.1.9'
set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 range 0 stop '192.168.1.254'

same as whats in the old quickstart guide

I can't reproduce it on my end. If you can give steps on latest rolling image that causes a failure, please open a task on here for it and I'll take a look.

config.boot from pre-subnet ID:

...
service {
    dhcp-server {
        hostfile-update
        shared-network-name LAN {
            subnet 192.168.1.0/24 {
                default-router "192.168.1.1"
                domain-name "localdomain"
                lease "86400"
                name-server "192.168.1.1"
                range 0 {
                    start "192.168.1.9"
                    stop "192.168.1.254"
                }
            }
        }
    }
...

Loading on latest rolling:

vyos@vyos# load config.boot
Loading configuration from 'config.boot'
Load complete. Use 'commit' to make changes effective.
[edit]
vyos@vyos# show service dhcp-server
+hostfile-update
+shared-network-name LAN {
+    subnet 192.168.1.0/24 {
+        lease 86400
+        option {
+            default-router 192.168.1.1
+            domain-name localdomain
+            name-server 192.168.1.1
+        }
+        range 0 {
+            start 192.168.1.9
+            stop 192.168.1.254
+        }
+        subnet-id 1
+    }
+