@Apachez , @gaige Hello Guys!
How do we want to continue here, please?

Are you able to update the status of this Mafifest, add a link to a new PR or other doc please?
Thank you

Are you able to update the status of this Mafifest, add a link to PR or other doc please?
Thank you

Are you able to update the status of this Mafifest, add a link to PR or other doc please?
Thank you

Thank you for the question.
The latest supported Ansible core version for this collection is 2.18.2
2.19+ unfortunately has a lot of changes that require the code rework, most notably, the community collections we use alongside with ours are not compatible as well (e.g. ansible.netcommon).
There is an issue https://github.com/vyos/vyos.vyos/issues/417 lodged to embrace 2.19+ at some point, but right now we have to wait for the adoption of this version by wider user base.

@Viacheslav @badger42 hi Guys! Why is this in the Ansible FR section?

@lingfish hi!
Sorry for taking so long

@lingfish Hi!
Which module are you using?

Work is here https://github.com/vyos/vyos.vyos/pull/433

The feature is really missing - I raised a PR to work on it https://github.com/vyos/vyos.vyos/pull/433

The feature is available in the latest Galaxy collection
https://galaxy.ansible.com/ui/repo/published/vyos/vyos/content/module/vyos_l3_interfaces/

More in Slack https://vyos-community.slack.com/archives/C027BSYGHPT/p1754577533265449
In general:

@nicolasberens hi!

I am working here on this use case https://github.com/vyos/vyos.vyos/pull/429

@nicolasberens Raising PR https://github.com/vyos/vyos.vyos/pull/430 to make vyos_config and cliconf less greedy

Hi @nicolasberens
That is interesting - when I use rule 5 for example - there is also no change

Additional details from Slack:
it is not only 1st run. He runs his playbook for 3 routers. Only one works without problems. He says that the configs are the same and the version is - 1.4.3.
Ansible verbose info

@a.apostoliuk hi!
Can we have:

Hello @nicolasberens
Apologies for this taking too long to respond.
I investigated further and found that community module function netcommon.CliConf inserts an extra space, thus breaking the long lines and causing diff to generate, which, in turns, impacts the idempotency of the VyOS modules.

So, I tried a few approaches here - in particular, I coded logic to preserve 'set' commands if they are in running config and there is a corresponding 'delete' clause, to we do see 'delete' and 'set' commands in the config to compare.
Despite this, the Ansible connnection.get_diff does not work with this well, as it tends to remove 'delete' from the resultant set as not making sense (it kind of being over-smart here)

That is clear now, thanks @nicolasberens
(Sorry, I must have misspelled your username)

@nicholaschaffeee Hi!
Are you able to describe your use case above?

As an example (and the reason why i try to solve this issue the way i am doing it right now), the junos module (https://docs.ansible.com/ansible/latest/collections/junipernetworks/junos/junos_config_module.html#ansible-collections-junipernetworks-junos-junos-config-module) support this exact behaviour. So it was easy to adapt this for our vyos firewalls.

It seems that community plugin netcommon network_cli breaks long lines resulting in diff. I tried ansible_terminal_width but no luck
I will be looking for some workarounds, unless there is already an open issue with Netcommon

I can see the community module we use (necommon/network_cli) actually returns the running config with a broken long strings - it inserts extra space

Hi,
I am testing against 1.4.2, via pylibssh, - I see 4096-long one does break idempotency but I see no Exception
I will retest with vyos_user

Hi @nicolasberens!
I believe the module is configured to match line by line by default and only work out on deltas in the config.
So if in the active Ansible session, the module does not sense changes after 'delete' (because there are none as yet, since the command is not applied) - At start, the module retrieves the current configuration and process it, then issues a set of commands.
Either having two separate tasks to delete first, then to set works, or the example below also works.

Hi All,
Looking into this

https://github.com/vyos/vyos.vyos/pull/418

Checking this and PR190 that claims to address the issues. Preliminary comment on the PR190:

https://github.com/vyos/vyos.vyos/pull/413

https://github.com/vyos/vyos.vyos/pull/412 to fix it

There was no a change - I tested with the existing code in trunk and could not replicate the issue - hence the question, given this is a pretty old bug report

This seems to be implemented:

https://github.com/vyos/vyos.vyos/pull/404

https://github.com/vyos/vyos.vyos/pull/402

https://github.com/vyos/vyos.vyos/pull/402

Hi,
I tested with 520-700+ character long strings and the bug is not evident in 1.3- or1.4+ versions
Can you please re-rest and advise this issue still persist

Are we happy with the above patch (fixing the terminal)?

After some investigation, it can be advised, that the described issue is to do with netcomm_cli module implementation used by VyOS Ansible Galaxy - namely, the ansible_net_version is set for a connection and stays so until reconnects and re-reads the modified hostname.
As such, this is currently outside of the collection's control.
That said, the issue can be easily avoided by reading ansible_facts mid-playbook:
Example Playbook:

https://github.com/vyos/vyos.vyos/pull/400

@pasik Hi mate! Were you the original reporter of this bug please?
If so, can you clarify a few questions I asked above?
thank you

Can we close it?

I cannot see the virtual interface names are supported in 1.3-1.5 -

Just a single one to go https://github.com/vyos/vyos.vyos/pull/395

PR399 is ready for review

Attempting to re-init work here https://github.com/vyos/vyos.vyos/pull/399

https://github.com/vyos/vyos.vyos/pull/398 - Ready

I will look into after https://github.com/vyos/vyos.vyos/pull/387

I can look into this after https://github.com/vyos/vyos.vyos/pull/387 is actioned