This PR merged. Closing the issue
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 16 2024
May 16 2024
May 12 2024
May 12 2024
Vijayakumar closed T6316: need to add automatic assignment of reviewers from reviewers team, a subtask of T6309: Check code quality with CodeQL, as Resolved.
Vijayakumar closed T6316: need to add automatic assignment of reviewers from reviewers team as Resolved.
Vijayakumar added a comment to T6316: need to add automatic assignment of reviewers from reviewers team.
Vijayakumar closed T6315: Add Codeql reusable action workflow, a subtask of T6309: Check code quality with CodeQL, as Resolved.
Merged, closing the issue
May 9 2024
May 9 2024
Vijayakumar added a comment to T6316: need to add automatic assignment of reviewers from reviewers team.
@syncer Any idea why conflict check fails for this PR https://github.com/vyos/vyos-1x/actions/runs/9015620312 ?
Ok,
Reviewers' assignment from the workflow can be removed (as it will be handled globally using codeowner file)
Raised PR,. Please check
https://github.com/vyos/vyos-1x/pull/3432
there is some issue https://github.com/vyos/vyos-1x/actions/runs/9013844673/job/24765384018?pr=3431
Please approve https://github.com/vyos/vyos-1x/pull/3431
Vijayakumar added a comment to T6316: need to add automatic assignment of reviewers from reviewers team.
Added codeowner file and basis pr templates and checks
https://github.com/vyos/.github/pull/1
Please review the PR
May 8 2024
May 8 2024
Vijayakumar added a comment to T6316: need to add automatic assignment of reviewers from reviewers team.
Ok, Sure.
Added access to organization's .github repository
we probably want to keep PR templates and what else there too(will create separate task)
Sure, let's do it that way
Thanks @Vijayakumar
Vijayakumar added a comment to T6316: need to add automatic assignment of reviewers from reviewers team.
@syncer Just want to know whether we considered using the CODEOWNERS file to achieve this
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Vijayakumar changed the status of T6315: Add Codeql reusable action workflow, a subtask of T6309: Check code quality with CodeQL, from Needs reporter action to In progress.
Vijayakumar changed the status of T6315: Add Codeql reusable action workflow from Needs reporter action to In progress.
syncer edited projects for T6316: need to add automatic assignment of reviewers from reviewers team, added: GitHub Infrastructure; removed VyOS 1.4 Sagitta (1.4.0-epa3), VyOS 1.5 Circinus.
syncer edited projects for T6315: Add Codeql reusable action workflow, added: GitHub Infrastructure; removed VyOS 1.4 Sagitta (1.4.0-epa3), VyOS 1.5 Circinus.
syncer edited projects for T6310: Change branches for CodeQL on push, added: GitHub Infrastructure; removed VyOS 1.5 Circinus.
syncer edited projects for T6309: Check code quality with CodeQL, added: GitHub Infrastructure; removed VyOS 1.4 Sagitta (1.4.0-epa3), VyOS 1.5 Circinus.