PR:
https://github.com/vyos/vyos-1x/pull/2050

https://github.com/vyos/vyos-1x/pull/2049

It fixes for shaper but breaks the policer
Policer uses limits in tc filter

In T4989#150726, @daniil wrote:

Now the traffic limiter is broken.

 interface br100 {
     ingress 1G-in
 }
 policy {
     limiter 1G-in {
         default {
             bandwidth 1gbit
             burst 125000000b
         }
     }
}

tc filter show dev br100 ingress

is empty, upload traffic is not limited.

Now the traffic limiter is broken.

Fixed in https://github.com/vyos/vyos-1x/pull/2047 https://vyos.dev/T5256

set qos interface eth0 egress 'test'
set qos policy shaper test bandwidth '330mbit'
set qos policy shaper test class 23 bandwidth '50%'
set qos policy shaper test class 23 match icmpv4 ip protocol 'icmp'
set qos policy shaper test default bandwidth '300mbit'
set qos policy shaper test default queue-type 'fair-queue'

in the VyOS 1.4-rolling-202306190317

set qos interface eth0 egress 'test'
set qos policy shaper test bandwidth '300bit'
set qos policy shaper test class 100 bandwidth '150mbit'
set qos policy shaper test class 100 burst '3760k'
set qos policy shaper test class 100 match internal mark '100'
set qos policy shaper test class 100 queue-type 'fq-codel'
set qos policy shaper test default bandwidth '20mbit'
set qos policy shaper test default burst '188k'
set qos policy shaper test default queue-type 'fq-codel'

comimt

DEBUG/QoS: tc qdisc replace dev eth0 root handle 1: htb r2q 1 default 65
DEBUG/QoS: tc class replace dev eth0 parent 1: classid 1:1 htb rate 300
DEBUG/QoS: tc class replace dev eth0 parent 1:1 classid 1:64 htb rate 150000000 burst 3760k quantum 1514
DEBUG/QoS: tc qdisc replace dev eth0 parent 1:64 sfq
DEBUG/QoS: tc class replace dev eth0 parent 1:1 classid 1:65 htb rate 20000000 burst 188k quantum 1514 prio 20
DEBUG/QoS: tc qdisc replace dev eth0 parent 1:65 sfq
DEBUG/QoS: tc qdisc replace dev eth0 parent 1:64 fq_codel quantum 1514 flows 1024 interval 100 interval 100 target 5 noecn
DEBUG/QoS: tc filter replace dev eth0 parent 1: protocol all handle 100 fw flowid 1:64

@MartB Could you test it? Should be fixed in vyos-1.4-rolling-202306190317-amd64.iso

Not sure about ipv6, requires more tests, but ip should work
PR https://github.com/vyos/vyos-1x/pull/2048

Sorry, I did not find that issue during my initial search.
I guess we can close this issue as duplicate.
What is the correct way to do this in phabricator?

The similar task https://vyos.dev/T5154

This was a red herring: root cause in
https://vyos.dev/T5300

This is most likely due to a config error on boot, thus leaving the active config different from the saved config; cf.
'verification of port availability can return false negative on boot'
https://vyos.dev/T5300

In T4989#144426, @MartB wrote:

set qos policy shaper test bandwidth 100mbit
set qos policy shaper test class 10 bandwidth 50%

It wont be used right now if I add a class that uses a percentage, it will always use the interface speed.
The base __rate_convert should include some check if the "base" speed was already set.

Fix for match protocol https://github.com/vyos/vyos-1x/pull/2047

PR https://github.com/vyos/vyos-1x/pull/2047

It expects ip protocol 1 instead of 'ip protocol icmp' in tc
wrong generation for protocols

PR https://github.com/vyos/vyos-1x/pull/2046

https://github.com/vyos/vyos-build/pull/363

After reboot, I connect to the node and execute reboot again without any config change
But I still see a Warning, that looks like a bug in this case.

PR:
https://github.com/vyos/vyos-1x/pull/2045

If class['bandwidth'] == auto then we should get global bandwidth

PR https://github.com/vyos/vyos-1x/pull/2044
Config

The same config in 1.3 doesn't have tc filter in 1.3

It's time to separate this task into subtasks.