Page MenuHomeVyOS Platform

Warn the user about unsaved config on reboot/shutdown attempts
Closed, ResolvedPublic

Description

Currently the system will cheerfully reboot if it has unsaved config changes and those changes will be lost. That's not very nice — if commit archive is enabled, the user can restore those changes, but if lost changes break the network setup, and there's no OOB access to the router, things can get really nasty.

We should add a warning message to remind the user if there are unsaved changes, and probably remind them how to save it as well.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

Viacheslav changed the task status from Open to Needs testing.Jun 7 2023, 10:11 AM

After reboot, I connect to the node and execute reboot again without any config change
But I still see a Warning, that looks like a bug in this case.

vyos@r14:~$ uptime
 11:49:53 up 0 min,  1 user,  load average: 0.75, 0.19, 0.06
vyos@r14:~$ 
vyos@r14:~$ reboot now
Warning: there are unsaved configuration changes!
Run 'save' command if you do not want to lose those changes after reboot/shutdown.

This is most likely due to a config error on boot, thus leaving the active config different from the saved config; cf.
'verification of port availability can return false negative on boot'
https://vyos.dev/T5300