Page MenuHomeVyOS Platform
Create Task
Maniphest T8347

Add all Python files under vyos-1x/python/* to the Pylint check
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Previously only files under the following locations

  • python/vyos/ifconfig/*.py
  • python/vyos/utils/*.py

got inspected by PyLint. This actually missed out all files under python/*.py itself.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFEATURE REQUESTc-poT7787 Make "unused-import" check mandatory
 ResolvedFEATURE REQUESTc-poT8347 Add all Python files under vyos-1x/python/* to the Pylint check

Event Timeline

c-po created this task.Mar 5 2026, 8:45 PM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po updated the task description. (Show Details)
c-po edited projects, added VyOS Rolling, VyOS 1.5 Circinus (Circinus-Next); removed VyOS 1.4 Sagitta (1.4.4), VyOS 1.5 Circinus (2025.11).
c-po removed subscribers: pasik, c-po.
c-po added a comment.Mar 5 2026, 9:22 PM

https://github.com/vyos/vyos-1x/pull/5031

pasik subscribed.Mar 6 2026, 8:20 AM
c-po mentioned this in rVYOSONEXdda6740789f8: template: T8347: for netifaces set "pylint: disable = no-name-in-module".Mar 7 2026, 7:38 PM
c-po mentioned this in rVYOSONEXa7457202b82f: configverify: T8347: fix use of undefined variable for CA certs.
c-po mentioned this in rVYOSONEX838cf65b1c18: remote: T8347: fix variable assignment for try/except block.
c-po mentioned this in rVYOSONEX2d73f1e8195a: remote: T8347: avoid Python requests module dynamic alias for urllib3.
c-po mentioned this in rVYOSONEX8e9e278750ee: vyos.debug: T8347: fix UnboundLocalError in try/finally statement.
c-po mentioned this in rVYOSONEX5b1b2b8d9a05: Makefile: T8347: enable pylint for all files under python/* path.
Restricted Repository Identity mentioned this in rVYOSONEX36542e14afbb: Merge pull request #5031 from c-po/pylint-t8347.Mar 7 2026, 7:38 PM
c-po moved this task from Need Triage to Completed on the VyOS Rolling board.Mar 7 2026, 9:19 PM
c-po closed this task as Resolved.Mar 18 2026, 8:00 AM
dmbaturin edited projects, added VyOS 1.5 Circinus (2026.03); removed VyOS 1.5 Circinus (Circinus-Next).Mar 18 2026, 2:43 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Feature (new functionality) to Internal change (not visible to end users).