Page MenuHomeVyOS Platform
Create Task
Maniphest T7787

Make "unused-import" check mandatory
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Currently our make target for "unused-imports" check is optional and a suggestion.

As we now also use pylint to check for missing imports and code issues, we also will make the unused import checker mandatory.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFEATURE REQUESTc-poT7787 Make "unused-import" check mandatory
 ResolvedBUGc-poT7355 Cleanup unused Python3 imports

Event Timeline

c-po created this task.Sep 4 2025, 2:33 PM
c-po claimed this task.
c-po triaged this task as Low priority.
c-po added a subtask: T7355: Cleanup unused Python3 imports.
pasik subscribed.Sep 4 2025, 4:07 PM
c-po added a comment.Sep 4 2025, 7:39 PM

https://github.com/vyos/vyos-1x/pull/4695

c-po changed the task status from Open to In progress.Sep 4 2025, 7:39 PM
c-po edited projects, added VyOS 1.4 Sagitta (1.4.4), VyOS 1.5 Circinus (1.5-stream-2025-Q3); removed VyOS 1.5 Circinus.
c-po mentioned this in rVYOSONEX5fee0201535f: T7787: Makefile check for unused-imports should be mandatory.Sep 5 2025, 5:42 AM
Restricted Repository Identity mentioned this in rVYOSONEXc99f1c058793: Merge pull request #4695 from c-po/mandatory-unused-imports-check.Sep 5 2025, 5:42 AM
c-po moved this task from Need Triage to Completed on the VyOS Rolling board.Sep 5 2025, 7:12 PM
c-po closed subtask T7355: Cleanup unused Python3 imports as Resolved.Sep 5 2025, 7:26 PM
c-po closed this task as Resolved.Sep 5 2025, 7:38 PM
c-po moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
c-po moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.4) board.
c-po mentioned this in rVYOSONEXa5b55e588acf: Makefile: T7787: error out early if pylint fails.Sep 18 2025, 2:20 PM
Restricted Repository Identity mentioned this in rVYOSONEX05b826ae7294: Merge pull request #4731 from c-po/openssh-T7787.Sep 18 2025, 2:20 PM
dmbaturin edited projects, added VyOS 1.5 Circinus (2025.11); removed VyOS 1.5 Circinus (1.5-stream-2025-Q3), VyOS 1.4 Sagitta (1.4.4), VyOS Rolling.Thu, Nov 13, 12:39 AM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Feature (new functionality) to Internal change (not visible to end users).