Page MenuHomeVyOS Platform

`show monitoring protocols bgp` doesn't work with frr
Closed, ResolvedPublicBUG

Description

Some incompatible changes from frr

vyos@syncer-home-rtr:~$ show monitoring protocols bgp 
% Unknown command: show debugging bgp

http://docs.frrouting.org/en/latest/bgp.html#debugging
it´s more extensive now, wondering if we should add additional options to CLI

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Issues in third-party code
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

syncer triaged this task as Normal priority.Sep 6 2018, 6:41 PM
syncer created this task.
syncer created this object with visibility "Public (No Login Required)".
syncer changed the subtype of this task from "Task" to "Bug".Oct 18 2018, 5:40 AM

It looks like the VyOS has the old command syntax.

[email protected]:~$ monitor protocol bgp enable keepalives 
BGP keepalives debugging is on
[email protected]:~$ 
[email protected]:~$ monitor protocol bgp enable events 
% Unknown command: debug bgp events 
[email protected]:~$ 
[email protected]:~$ monitor protocol bgp enable 
Possible completions:
  events        Enable BGP events debugging
  filters       Enable BGP filters debugging
  fsm           Enable BGP fsm debugging
  keepalives    Enable BGP keepalives debugging
  messages      Enable Border Gateway Protocol (BGP) messages debugging
  rib           Enable BGP rib debugging
  updates       Enable BGP updates debugging

FRR vtysh:

# debug bgp 
  allow-martians   BGP allow martian next hops
  as4              BGP AS4 actions
  bestpath         BGP bestpath
  flowspec         BGP allow flowspec debugging entries
  keepalives       BGP Neighbor Events
  labelpool        label pool
  neighbor-events  BGP Neighbor Events
  nht              BGP nexthop tracking events
  pbr              BGP policy based routing
  update-groups    BGP update-groups
  updates          BGP updates
  vnc              VNC information
  vpn              VPN routes
  zebra            BGP Zebra messages

PR https://github.com/vyos/vyatta-op-quagga/pull/4/commits/7659873869d92c9ec6b363db7e06d2ba5b41e5f6
New syntax for commands "monitor protocol bgp enable", "monitor protocol bgp disable"

[email protected]:~$ monitor protocol bgp enable 
Possible completions:
  allow-martians
                Enable BGP martians next hops debugging
  as4           Enable BGP allow AS4 actions debugging
  bestpath      Enable BGP allow best path debugging
  flowspec      Enable BGP allow flowspec debugging
  keepalives    Enable BGP keepalives debugging
  labelpool     Enable BGP label pool  debugging
  neighbor-events
                Enable BGP Neighbor events debugging
  nht           Enable BGP next hop tracking debugging
  pbr           Enable BGP policy based routing debugging
  rib           Enable BGP rib debugging
  update-groups Enable BGP update groups debugging
  updates       Enable BGP updates debugging
  vnc           Enable values
[email protected]:~$ monitor protocol bgp enable allow-martians 
BGP allow_martian next hop debugging is on
[email protected]:~$ monitor protocol bgp enable as4
BGP as4 debugging is on
[email protected]:~$ 
[email protected]:~$ vtysh -c "show debug"
Zebra debugging status:

BGP debugging status:
  BGP as4 debugging is on
  BGP allow martian next hop debugging is on

PR https://github.com/vyos/vyatta-op/pull/32
Fix "show monitoring" command.

[email protected]:~$ show monitoring 
Zebra debugging status:

RIP debugging status:

RIPng debugging status:

OSPF6 debugging status:

BGP debugging status:
  BGP as4 debugging is on
  BGP keepalives debugging is on
  BGP neighbor-events debugging is on
  BGP next-hop tracking debugging is on
  BGP update-groups debugging is on
  BGP updates debugging is on (inbound)
  BGP updates debugging is on (outbound)
  BGP zebra debugging is on
  BGP allow martian next hop debugging is on
  BGP flowspec debugging is on
  BGP labelpool debugging is on
  BGP policy based routing debugging is on

Static debugging status

BFD debugging status:

[email protected]:~$
Unknown Object (User) changed the task status from Open to Backport pending.May 13 2020, 10:34 AM
Unknown Object (User) added a project: VyOS 1.2 Crux (VyOS 1.2.6).
dmbaturin changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).
dmbaturin changed Why the issue appeared? from Will be filled on close to Issues in third-party code.
dmbaturin set Is it a breaking change? to Perfectly compatible.
erkin renamed this task from show monitoring protocols bgp not works with frr to `show monitoring protocols bgp` doesn't work with frr.Sep 9 2020, 12:56 PM
dmbaturin set Issue type to Bug (incorrect behavior).