Add file sync and atomic write to config save script
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	jestabro
	Aug 12 2025, 4:15 PM

Description

Add explicit sync and atomic write to vyos-save-config.py.

Details

Version: -
Is it a breaking change?: Perfectly compatible
Issue type: Bug (incorrect behavior)

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	FEATURE REQUEST	None	T6472 Implement Atomic Write Operations for Config Files
Resolved	BUG	jestabro	T7709 Add file sync and atomic write to config save script
Resolved	BUG	jestabro	T7836 The /config bind mount does not respect inode updates
Resolved	BUG	jestabro	T7994 Image installer doesn't detect previous installation
Resolved	BUG	jestabro	T8257 Image installer copies wrong config from previous installations created with legacy config bind construction
Open	BUG	jestabro	T8265 Image installation does not see previous installations that were created from qcow2 image
Open	BUG	jestabro	T8335 Management of the config hint belongs in a post installation step, not image install

Event Timeline

jestabro created this task.Aug 12 2025, 4:15 PM

jestabro triaged this task as Normal priority.

pasik subscribed.Aug 12 2025, 4:21 PM

PR:
https://github.com/vyos/vyos-1x/pull/4657

jestabro updated the task description. (Show Details)Aug 13 2025, 2:37 PM

jestabro added a parent task: T6472: Implement Atomic Write Operations for Config Files.

jestabro mentioned this in rVYOSONEXc140f827f311: T7709: add atomic write for config file save.Aug 14 2025, 2:13 PM

Restricted Repository Identity mentioned this in rVYOSONEX4c8f5f0e0b7a: Merge pull request #4657 from jestabro/sync-config-on-save.Aug 14 2025, 2:13 PM

jestabro mentioned this in rVYOSONEX9f80e374f672: T7759: Revert "T7709: add atomic write for config file save".Aug 28 2025, 9:40 AM

Restricted Repository Identity mentioned this in rVYOSONEX380b7c50cf5e: Merge pull request #4683 from jestabro/revert-config-save-atomic.Aug 28 2025, 9:40 AM

jestabro mentioned this in T7836: The /config bind mount does not respect inode updates.Sep 17 2025, 3:29 PM

jestabro added a subtask: T7836: The /config bind mount does not respect inode updates.

The PR was reverted https://github.com/vyos/vyos-1x/pull/4683

Now that T7836 is resolved, the revised version will be submitted as PR for Rolling; change tag for Circinus to Q4. A workaround is still scheduled for Sagitta 1.4.4.

jestabro renamed this task from Sync file on config save to Add file sync and atomic write to config save script.Sep 25 2025, 3:37 AM

Revised PR:
https://github.com/vyos/vyos-1x/pull/4753

jestabro mentioned this in rVYOSONEX629ff86edb9e: T7709: add utils write_file_sync and write_file_atomic.Sep 25 2025, 2:36 PM

jestabro mentioned this in rVYOSONEXfbdf1fb8914a: T7709: use write_file_sync/atomic in vyos-save-config.py script.

jestabro mentioned this in rVYOSONEXc8dde333d96c: T7709: use standard script vyos-save-config.py for vyconf.

jestabro mentioned this in rVYOSONEX95a7aec65de1: T7709: add smoketest for config save.

Restricted Repository Identity mentioned this in rVYOSONEX7a29b1596a10: Merge pull request #4753 from jestabro/config-save-sync-atomic.Sep 25 2025, 2:36 PM

jestabro edited projects, added VyOS 1.5 Circinus (1.5-stream-2025-Q3); removed VyOS 1.5 Circinus (1.5-stream-2025-Q4).Sep 25 2025, 7:40 PM

jestabro closed subtask T7836: The /config bind mount does not respect inode updates as Resolved.Oct 1 2025, 6:28 PM

jestabro mentioned this in T7907: config-mgmt: add baseline archived config file on first boot to avoid misleading error messages.Oct 3 2025, 4:23 PM

jestabro mentioned this in rVYOSONEXad5452c19e73: T7907: archive config file on first boot to avoid misleading log entry.Oct 6 2025, 7:30 PM

jestabro moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.Oct 7 2025, 12:04 AM