Page MenuHomeVyOS Platform
Create Task
Maniphest T7709

Add file sync and atomic write to config save script
Open, NormalPublicBUG
Actions

Description

Add explicit sync and atomic write to vyos-save-config.py.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

jestabro created this task.Aug 12 2025, 4:15 PM
jestabro triaged this task as Normal priority.
pasik subscribed.Aug 12 2025, 4:21 PM
jestabro added a comment.Aug 12 2025, 6:33 PM

PR:
https://github.com/vyos/vyos-1x/pull/4657

jestabro updated the task description. (Show Details)Aug 13 2025, 2:37 PM
jestabro added a parent task: T6472: Implement Atomic Write Operations for Config Files.
jestabro mentioned this in rVYOSONEXc140f827f311: T7709: add atomic write for config file save.Aug 14 2025, 2:13 PM
Restricted Repository Identity mentioned this in rVYOSONEX4c8f5f0e0b7a: Merge pull request #4657 from jestabro/sync-config-on-save.Aug 14 2025, 2:13 PM
jestabro mentioned this in rVYOSONEX9f80e374f672: T7759: Revert "T7709: add atomic write for config file save".Aug 28 2025, 9:40 AM
Restricted Repository Identity mentioned this in rVYOSONEX380b7c50cf5e: Merge pull request #4683 from jestabro/revert-config-save-atomic.Aug 28 2025, 9:40 AM
jestabro mentioned this in T7836: The /config bind mount does not respect inode updates.Sep 17 2025, 3:29 PM
jestabro added a subtask: T7836: The /config bind mount does not respect inode updates.
Viacheslav subscribed.Sep 24 2025, 11:53 PM

The PR was reverted https://github.com/vyos/vyos-1x/pull/4683

jestabro edited projects, added VyOS 1.5 Circinus (1.5-stream-2025-Q4); removed VyOS 1.5 Circinus (1.5-stream-2025-Q3).Sep 25 2025, 12:19 AM

Now that T7836 is resolved, the revised version will be submitted as PR for Rolling; change tag for Circinus to Q4. A workaround is still scheduled for Sagitta 1.4.4.

jestabro renamed this task from Sync file on config save to Add file sync and atomic write to config save script.Sep 25 2025, 3:37 AM
jestabro added a comment.Sep 25 2025, 4:03 AM

Revised PR:
https://github.com/vyos/vyos-1x/pull/4753

jestabro mentioned this in rVYOSONEX629ff86edb9e: T7709: add utils write_file_sync and write_file_atomic.Sep 25 2025, 2:36 PM
jestabro mentioned this in rVYOSONEXfbdf1fb8914a: T7709: use write_file_sync/atomic in vyos-save-config.py script.
jestabro mentioned this in rVYOSONEXc8dde333d96c: T7709: use standard script vyos-save-config.py for vyconf.
jestabro mentioned this in rVYOSONEX95a7aec65de1: T7709: add smoketest for config save.
Restricted Repository Identity mentioned this in rVYOSONEX7a29b1596a10: Merge pull request #4753 from jestabro/config-save-sync-atomic.Sep 25 2025, 2:36 PM
jestabro edited projects, added VyOS 1.5 Circinus (1.5-stream-2025-Q3); removed VyOS 1.5 Circinus (1.5-stream-2025-Q4).Sep 25 2025, 7:40 PM
jestabro closed subtask T7836: The /config bind mount does not respect inode updates as Resolved.Oct 1 2025, 6:28 PM
jestabro mentioned this in T7907: config-mgmt: add baseline archived config file on first boot to avoid misleading error messages.Oct 3 2025, 4:23 PM
jestabro mentioned this in rVYOSONEXad5452c19e73: T7907: archive config file on first boot to avoid misleading log entry.Oct 6 2025, 7:30 PM
jestabro moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.Oct 7 2025, 12:04 AM
jestabro moved this task from Need Triage to Completed on the VyOS Rolling board.
dmbaturin edited projects, added VyOS 1.5 Circinus (2025.11); removed VyOS 1.5 Circinus (1.5-stream-2025-Q3), VyOS 1.4 Sagitta (1.4.4), VyOS Rolling.Wed, Nov 12, 6:13 PM