Commit pre- and post-hooks will be called from the Python vyconf_session.commit function, as a proper separation of concerns.
Those calls will be protected by a lockf/fcntl lock consistent with the legacy locking mechanism; when all remaining references to the legacy lock file are removed, this can be migrated to use the BSD-type lock of vyos.utils.locking.
Description
Description
Details
Details
- Version
- -
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Feature (new functionality)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | jestabro | T7427 Replace legacy commit algorithm and data structures with vyconfd | |||
| Open | ENHANCEMENT | jestabro | T7352 Add remaining features to vyconf framework for smoketest success | ||
| Resolved | ENHANCEMENT | jestabro | T7365 vyconf: add locking and invocation of pre/post-commit hooks | ||
| Resolved | ENHANCEMENT | jestabro | T7455 Update config_mgmt module and scripts for vyconf compatibility | ||
| Resolved | ENHANCEMENT | jestabro | T7493 Add vyconf support for commit-confirm |
Event Timeline
Comment Actions
Locking added in PR
https://github.com/vyos/vyos-1x/pull/4505
pre/post-commit hooks tested but will not be added until update of config_mgmt system for vyconf-aware operation, cf. subtask.