Page MenuHomeVyOS Platform

Mirror PR: support rerun for failed mirrors
Closed, ResolvedPublic

Description

Christian Breunig

4:08 PM

@Vijayakumar
so the bot went crazy
https://github.com/VyOS-Networks/vyos-1x/pull/210/commits
it added multiple PRs to the mirrored PR

4:08
We now can not cherry-pick to circinus Need to add a manual PR now (edited)

Vijayakumar

4:55 PM

Ok, I think currently we dont have rerun capablity for failed mirror PRs.
Same gets accumulated to next successful mirror PRs.
Please let know if any solution to handle this.

Christian Breunig

5:11 PM

Well accumulation is very bad as it does not reflect the actual repository state in the public organisation - a rerun would be appreciated so everything is in sync (edited)

Vijayakumar

5:43 PM

Ok, Yes
Need some brainstorming/analysis on how to handle this.
Something like, each mirror pr workflow run need to check prev mirrored PR to make sure that it is upto date with source's closed PR before merging the given PR.
If not update date/missing, it has to do the mirroring for those and do the given one.
To start with, for now atleast it should not mirror (should fail) the given PR mirror incase previous closed PR in source is not mirrored.
So that we can fix the issue, them run the mirror manually for each missed PR.
I will do this, incase if you have any thoughts, pl let me know (edited)

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Event Timeline

Vijayakumar changed the task status from Open to In progress.
Vijayakumar triaged this task as High priority.
Vijayakumar created this object in space S1 VyOS Public.
Vijayakumar updated the task description. (Show Details)