Page MenuHomeVyOS Platform

Update mirror sync to use revised approach (mirror and repo-sync) - vyos-1x
Closed, ResolvedPublic

Description

Christian Breunig
🌴 5:35 PM
@daniil Baturin

@Viacheslav Hletenko
please note:
The PR mirror bot/functionality is broken and I'm in contact with
@Vijayakumar
source: https://github.com/vyos/gh-action-test-vyos-1x/pull/8/commits/c04a694a78dc62b475757a2fe67f031c51001a1c
mirror: https://github.com/VyOS-Networks/gh-action-test-vyos-1x/pull/1/commits/ccad64469053b609a242ec5bd0cdf8f33d6b2218
The commit IDs are different as the mirror is actually a entire new commit and not a mirror - you can easily spot it with the altered commit message.
This will alter the commit history and public repo current and mirror current will diverge, so we need to fix this

Viacheslav Hletenko
🏠 5:44 PM
So It does not do mirror, but does PR. I think it is expected for different orgs
As I see the logic is here https://github.com/VyOS-Networks/gh-action-test-vyos-1x/blob/beb220dd1c4a7c3c9bfe515dce8fedbfe99953ca/.github/workflows/create-pr.yml#L58-L70

Christian Breunig
🌴 5:56 PM
It does neither mirror nor PR. I creates an independent commit that is attached to a new PR.
Expected would be the exact same commit git format-patch added to a new PR.
@Vijayakumar
re-checks his logic, send him the details
5:57
https://github.com/VyOS-Networks/gh-action-test-vyos-1x/blob/beb220dd1c4a7c3c9bfe515dce8fedbfe99953ca/.github/workflows/create-pr.yml#L68
This is the problematic line which will break things in the future as the commit IDs will be different.
proper way would be:
git format-patch -Nyyy where yyy is the number of commits in the PR
then git am <filename>where filename is the name produces by above command

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Event Timeline

Vijayakumar renamed this task from Upadte mirror sync to use git format-patch to Update mirror sync to use git format-patch.
Vijayakumar triaged this task as High priority.
Vijayakumar created this object in space S1 VyOS Public.
vyosbot added a project: Restricted Project.Nov 4 2024, 6:08 AM
Vijayakumar renamed this task from Update mirror sync to use git format-patch to Update mirror sync to use revised approach (mirror and repo-sync).Dec 12 2024, 5:02 PM
Vijayakumar changed the task status from Open to In progress.
Vijayakumar renamed this task from Update mirror sync to use revised approach (mirror and repo-sync) to Update mirror sync to use revised approach (mirror and repo-sync) - vyos-1x.Dec 17 2024, 3:20 PM
Vijayakumar closed this task as Resolved.