Page MenuHomeVyOS Platform

Afer the migration from 1.3.x to 1.4.0 "/" character at the end of the users home directory path breaks login
Open, HighPublicBUG

Description

Configuration in VyOS 1.3.x

set system host-name VyOS-Test
set interfaces ethernet eth0 address 10.55.8.92/24
set service ssh
set system login user test full-name 'Test user'
set system login user test home-directory '/home/test/'
set system login user test authentication plaintext-password 'test123
commit
save

This works on VyOS 1.3.x ("/" at the end of the home directory path)

Updating VyOS instance:

vyos@vyos:~$ add system image vyos-1.4.0-generic-amd64.iso
Checking SHA256 checksums of files on the ISO image... OK.
Done!
What would you like to name this image? [1.4.0]:
OK.  This image will be named: 1.4.0
Installing "1.4.0" image.
Copying new release files...
Would you like to save the current configuration
directory and config file? (Yes/No) [Yes]:
Copying current configuration...
Would you like to save the SSH host keys from your
current configuration? (Yes/No) [Yes]:
Copying SSH keys...
Running post-install script...
Setting up grub configuration...
Done.

After the reboot in VyOS 1.4.0 Instance Inaccessible via SSH or Console:

[  OK  ] Reached target vyos.target - VyOS target.
         Starting systemd-update-ut… Record Runlevel Change in UTMP...
[  OK  ] Finished systemd-update-ut… - Record Runlevel Change in UTMP.
[   34.398912] vyos-router[1139]: Waiting for NICs to settle down: settled in 3sec..
[   39.330293] vyos-router[1139]: Mounting VyOS Config...done.
[   51.435144] vyos-router[1139]: Starting VyOS router: migrate configure failed!
[   52.162090] vyos-config[1145]: Configuration error

Welcome to VyOS - VyOS-Test ttyS0

VyOS-Test login: vyos
Password:

Login incorrect
VyOS-Test login: test
Password:

Login incorrect
VyOS-Test login:
Login timed out after 60 seconds.

Welcome to VyOS - VyOS-Test ttyS0

VyOS-Test login:

Attaching config.boot files

Details

Version
1.4
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

The problem is in the regex filter: https://github.com/vyos/vyos-1x/blob/3710c5879f5733d05aae6e156f74d62b73821b2d/interface-definitions/system_login.xml.in#L193

It needs to be modified to accept a trailing slash if this is allowed by the code that later will use a value.

This comment was removed by a.hajiyev.