Page MenuHomeVyOS Platform
Create Task
Maniphest T6734

Nginx - disable software version reporting
In progress, NormalPublicFEATURE REQUEST
Actions

Description

Do not report the nginx version.

Under the # HTTP Options, we need to add:
server_tokens off;

Details

Version
-
Is it a breaking change?
Behavior change
Issue type
Unspecified (please specify)

Related Objects
Search...

StatusSubtypeAssignedTask
OpenFEATURE REQUESTNoneT6733 Do not report software versions root task
In progressFEATURE REQUESTmwheelerT6734 Nginx - disable software version reporting

Event Timeline

syncer created this task.Sep 24 2024, 11:36 PM
syncer changed the task status from Open to In progress.
syncer triaged this task as Normal priority.
pasik subscribed.Sep 25 2024, 6:16 AM
vyosbot added a project: Restricted Project.Oct 14 2024, 8:16 AM
dmbaturin edited projects, added VyOS Rolling; removed Restricted Project.Oct 14 2024, 8:52 AM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Behavior change.
dmbaturin changed Issue type from Unspecified (please specify) to behavior-change.
syncer removed a project: VyOS 1.5 Circinus.Nov 1 2024, 8:10 PM
syncer moved this task from Need Triage to Backlog - Feature Requests on the VyOS Rolling board.
syncer added a subscriber: Global Notifications.Nov 1 2024, 9:19 PM
mwheeler subscribed.Jan 3 2025, 4:10 PM

PR: https://github.com/vyos/vyos-1x/pull/4273

c-po subscribed.Jan 3 2025, 4:26 PM

I wonder if we should not always disable this. I see no reason in exposing this information.

c-po assigned this task to mwheeler.Jan 3 2025, 4:26 PM
c-po changed Issue type from behavior-change to Unspecified (please specify).
c-po added a project: VyOS 1.5 Circinus.
mwheeler added a comment.Jan 3 2025, 4:47 PM

Usually I'm not a fan of changing default behavior, but I agree that there probably isn't much value in knowing the server version with how vyos manages the nginx config as a black box.

Is that the direction you'd like to go?

c-po added a comment.Jan 5 2025, 6:33 AM

https://github.com/vyos/vyos-1x/pull/4273

mwheeler added a comment.Jan 6 2025, 3:19 PM

Canceling PR 4273 because it has several commits that go in the wrong direction. Will submit a new PR with a different approach.

mwheeler added a comment.Jan 6 2025, 5:35 PM

Replacement PR: https://github.com/vyos/vyos-1x/pull/4282