Page MenuHomeVyOS Platform

interfaces: 20-to-21 -> migration fails if new system has less ethernet interfaces
Closed, ResolvedPublicBUG

Description

During a corner case where the configuration is migrated to a different system
with fewer ethernet interfaces, migration will fail during an image upgrade.

vyos.ethtool.Ethtool() is instantiated with an invalid interface leading to an
exception that kills the migrator

The following error was output:

vyos@vyos# load /usr/libexec/vyos/tests/config/bgp-evpn-l3vpn-pe-router
Loading configuration from '/usr/libexec/vyos/tests/config/bgp-evpn-l3vpn-pe-router'

Migration script error: /opt/vyatta/etc/config-migrate/migrate/interfaces/20-to-21: [Errno 1] failed to run command: ['/opt/vyatta/etc/con
fig-migrate/migrate/interfaces/20-to-21', '/tmp/tmprr8xf78f']
- op: set path: ['interfaces', 'ethernet', 'eth0', 'offload', 'gro'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth0', 'offload', 'gso'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth0', 'offload', 'sg'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth0', 'offload', 'tso'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth1', 'offload', 'gro'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth1', 'offload', 'gso'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth1', 'offload', 'sg'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth1', 'offload', 'tso'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth2', 'offload', 'gro'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth2', 'offload', 'gso'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth2', 'offload', 'sg'] value: None replace: True
- op: set path: ['interfaces', 'ethernet', 'eth2', 'offload', 'tso'] value: None replace: True

exit code: 1.

Details

Difficulty level
Easy (less than an hour)
Version
1.4.0
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po added a project: VyOS 1.5 Circinus.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.1) board.
c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.