Page MenuHomeVyOS Platform

http: remove virtual-host configuration in webserver
Closed, ResolvedPublicBUG

Description

As discussed with @jestabro both of us have not seen the adoption of the https virtual-host CLI option.

What it did?

  • Create multiple webservers each listening on a different IP/Port (but in the same VRF)
  • All webservers shared one common documentroot
  • All webservers shared the same SSL certificates
  • All webservers could have had individual allow-client configurations
  • API could be enabled for a particular virtual-host but was always enabled on the default host

This configuration tried to provide a full webserver via the CLI but VyOS is a router and the Webserver is there for an API or to serve files for a local-ui.

Changes

  • Remove support for virtual-hosts as it's an incomplete and thus mostly useless "thing"
  • Migrate all allow-client statements to one top-level allow statement

Details

Difficulty level
Hard (possibly days)
Version
1.4.0-rc1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Feature/functionality removal

Event Timeline

c-po changed the task status from Open to In progress.
c-po claimed this task.

Having support for vhost is handy when you dont want just to blindly share a single documentroot but have the ability to use multiple at a single host.

For example having http://crl.example.com and http://update.example.com end up at two different documentroots.

Well, the webserver is for an API - if you wan't to server files you can either use the default document root, or spawn a container. We should focus on packet pushing and administration.

c-po triaged this task as High priority.
c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.