Page MenuHomeVyOS Platform

Extend override-default script to allow embedded defaultValue settings
Closed, ResolvedPublicFEATURE REQUEST

Description

Existing examples of XML fragments overriding the defaultValue element are of the level leafNode, for example:
https://github.com/vyos/vyos-1x/blob/current/interface-definitions/interfaces-tunnel.xml.in#L209-L212

#include <include/interface/parameters-ttl.xml.i>
<leafNode name="ttl">
  <defaultValue>64</defaultValue>
</leafNode>

It is useful to generalize this to allow embedded settings:

#include <include/accel-ppp/radius-additions.xml.i>
 <node name="radius">
   <children>
     <leafNode name="timeout">
       <defaultValue>30</defaultValue>
     </leafNode>
     <leafNode name="acct-timeout">
       <defaultValue>30</defaultValue>
     </leafNode>
   </children>
 </node>

This simply requires cleaning up the empty paths left by the override and merging of defaultValue elements.

Details

Version
-
Is it a breaking change?
Perfectly compatible

Event Timeline

jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro updated the task description. (Show Details)
jestabro moved this task from Open to Finished on the VyOS 1.5 Circinus board.
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.