Page MenuHomeVyOS Platform
Create Task
Maniphest T5543

Fix source address handling in static joins
Closed, ResolvedPublicBUG
Actions

Description

The following command expects to join source-specific multicast group 239.1.2.3 on interface eth0,
where the source address is 192.0.2.1.

set protocols igmp interface eth0 join 239.1.2.3 source 192.0.2.1



This command should generate FRR config:



interface eth0
   ip igmp
   ip igmp join 239.1.2.3 192.0.2.1
exit



However, there is a bug in the Jinja template where condition ifaces[iface].gr_join[group] is mostly evaluated as false because iface is a loop variable from another loop.
Details
Version 
1.4 
Is it a breaking change? 
Perfectly compatible 
Issue type 
Bug (incorrect behavior) 
Related Objects
Event Timeline
vfreex created this task.Sep 3 2023, 11:17 AM
PR https://github.com/vyos/vyos-1x/pull/2196
Restricted Repository Identity mentioned this in rVYOSONEX630d40046b4f: T5543: IGMP: fix source address handling in static joins.Sep 3 2023, 11:28 AM
syncer closed this task as Unknown Status.Sep 3 2023, 11:43 AM
syncer assigned this task to Viacheslav.
syncer added a project: VyOS 1.3 Equuleus (1.3.4).
syncer moved this task from Open to Backport Candidates on the VyOS 1.4 Sagitta board.
syncer added subscribers: Viacheslav, syncer.
@Viacheslav, can you backport this to 1.3
syncer moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus (1.3.4) board.Sep 3 2023, 11:43 AM
syncer triaged this task as Normal priority.Sep 3 2023, 5:44 PM
Viacheslav added a comment.Sep 4 2023, 2:18 PM
@syncer  At first glance, the generated config is correct for VyOS 1.3-stable-202308240442



set protocols igmp interface eth0 join 239.1.2.3 source '192.0.2.1'
set protocols igmp interface eth1 join 239.1.2.3
set protocols igmp interface eth2



Generated FRR



!
interface eth0
 ip igmp
 ip igmp join 239.1.2.3 192.0.2.1
!
interface eth1
 ip igmp
 ip igmp join 239.1.2.3
!
interface eth2
 ip igmp
!
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.4).Dec 17 2023, 11:34 PM
syncer moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus (1.3.6) board.
Viacheslav changed the task status from Unknown Status to Resolved.Jan 19 2024, 10:13 PM
Viacheslav added a comment.Jan 19 2024, 10:17 PM
IGMP was migrated to PIM https://github.com/vyos/vyos-1x/commit/383231dae8c01ea58d0c956688ecd87f739be97e
dmbaturin mentioned this in 1.3.6.Feb 3 2024, 1:59 AM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.0); removed VyOS 1.4 Sagitta.Oct 12 2024, 8:15 AM
syncer added a project: VyOS Rolling.Oct 12 2024, 8:15 AM
syncer moved this task from Need Triage to Completed on the VyOS Rolling board.
syncer moved this task from Backlog to Finished on the VyOS 1.3 Equuleus (1.3.6) board.
syncer edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.4 Sagitta (1.4.0).
syncer moved this task from Backport Candidates to Finished on the VyOS 1.4 Sagitta board.