Page MenuHomeVyOS Platform
Create Task
Maniphest T5543

Fix source address handling in static joins
Closed, ResolvedPublicBUG
Actions

Description

The following command expects to join source-specific multicast group 239.1.2.3 on interface eth0,
where the source address is 192.0.2.1.

set protocols igmp interface eth0 join 239.1.2.3 source 192.0.2.1



This command should generate FRR config:



interface eth0
   ip igmp
   ip igmp join 239.1.2.3 192.0.2.1
exit



However, there is a bug in the Jinja template where condition ifaces[iface].gr_join[group] is mostly evaluated as false because iface is a loop variable from another loop.
Details
Difficulty level 
Easy (less than an hour) 
Version 
1.4 
Why the issue appeared? 
Will be filled on close 
Is it a breaking change? 
Perfectly compatible 
Issue type 
Bug (incorrect behavior) 
Related Objects
Mentioned In 
1.3.6 
Event Timeline
vfreex created this task.Sep 3 2023, 11:17 AM
PR https://github.com/vyos/vyos-1x/pull/2196
syncer changed the task status from Open to Backport pending.Sep 3 2023, 11:43 AM
syncer assigned this task to Viacheslav.
syncer added a project: VyOS 1.3 Equuleus (1.3.4).
syncer moved this task from Need Triage to Backport Candidates on the VyOS 1.4 Sagitta board.
syncer added subscribers: Viacheslav, syncer.
@Viacheslav, can you backport this to 1.3
syncer moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus (1.3.4) board.Sep 3 2023, 11:43 AM
syncer triaged this task as Normal priority.Sep 3 2023, 5:44 PM
Viacheslav added a comment.Sep 4 2023, 2:18 PM
@syncer  At first glance, the generated config is correct for VyOS 1.3-stable-202308240442



set protocols igmp interface eth0 join 239.1.2.3 source '192.0.2.1'
set protocols igmp interface eth1 join 239.1.2.3
set protocols igmp interface eth2



Generated FRR



!
interface eth0
 ip igmp
 ip igmp join 239.1.2.3 192.0.2.1
!
interface eth1
 ip igmp
 ip igmp join 239.1.2.3
!
interface eth2
 ip igmp
!
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.4).Dec 17 2023, 11:34 PM
syncer moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus (1.3.6) board.
Viacheslav closed this task as Resolved.Jan 19 2024, 10:13 PM
Viacheslav added a comment.Jan 19 2024, 10:17 PM
IGMP was migrated to PIM https://github.com/vyos/vyos-1x/commit/383231dae8c01ea58d0c956688ecd87f739be97e
dmbaturin mentioned this in 1.3.6.Feb 3 2024, 1:59 AM