UDP broadcast relay - missing verify() that relay interfaces have an IP address assigned
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	cuongdt1994
	Jun 24 2023, 7:11 PM

Description

In Example:

To forward all broadcast packets received on UDP port 1900 on eth3, eth4 or eth5 to all other interfaces in this configuration.

set service broadcast-relay id 1 description 'SONOS'
set service broadcast-relay id 1 interface 'eth3'
set service broadcast-relay id 1 interface 'eth4'
set service broadcast-relay id 1 interface 'eth5'
set service broadcast-relay id 1 port '1900'

When set more 2 interface, service udp broadcast not running and have error:

And here when remove interface:

Details

Difficulty level: Easy (less than an hour)
Version: Vyos 1.3.3
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Perfectly compatible
Issue type: Bug (incorrect behavior)

Related Objects

Mentioned In: 1.3.4

Event Timeline

cuongdt1994 created this task.Jun 24 2023, 7:11 PM

if len(config.get('interface', [])) < 2 or len(config.get('interface', [])) > 2:
           raise ConfigError('Only two interfaces are required for udp broadcast relay "{instance}"')

Is it ok? @jestabro

PR: https://github.com/vyos/vyos-1x/pull/2056
PR: https://github.com/vyos/vyos-1x/pull/2055

pasik added a subscriber: pasik.Jun 25 2023, 2:30 PM

cuongdt1994 closed this task as Resolved.Jun 25 2023, 4:39 PM

Actually this uncovered a "bug" that there is no verify() section that validates if the configured interfaces actually have an IP address configured.

UDP broadcast relay agent won't work if there is no IP address configured.

c-po renamed this task from UDP Broadcast Broken to UDP broadcast relay - missing verify() that relay interfaces have an IP address assigned.Jun 25 2023, 4:49 PM

c-po reopened this task as In progress.

c-po claimed this task.

c-po triaged this task as Low priority.

c-po edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).

c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.Jun 25 2023, 6:12 PM

PR for 1.3 https://github.com/vyos/vyos-1x/pull/2057

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.4) board.Jun 25 2023, 6:27 PM

c-po closed this task as Resolved.Jun 30 2023, 7:50 PM

dmbaturin mentioned this in 1.3.4.Sep 14 2023, 1:07 PM