Maniphest T5308

Remove workarounds for incorrect defaults in get_interface_dict
Closed, ResolvedPublicENHANCEMENT
Actions

Assigned To

Authored By

	jestabro
	Jun 22 2023, 1:40 PM

Tags

Referenced Files

None

Subscribers

Description

Using the revised vyos.xml lib (T5218) and the optional argument with_defaults, added to get_config_dict in T5228, one can remove the various workarounds required by the bug T2665.

Details

Difficulty level: Normal (likely a few hours)
Version: vyos-1.4
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Improvement (missing useful functionality)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG	jestabro	T2665 vyos.xml.defaults for tag nodes
		Resolved	ENHANCEMENT	jestabro	T5218 Revise vyos xml lib for bug fixes and extensions
		Resolved	ENHANCEMENT	jestabro	T5228 Simplify get_config_dict and add argument with_defaults
		Resolved	ENHANCEMENT	jestabro	T5308 Remove workarounds for incorrect defaults in get_interface_dict
		Resolved	ENHANCEMENT	jestabro	T5319 Remove remaining workarounds for incorrect defaults
		Resolved	BUG	jestabro	T5350 Confusing warning message when committing VRRP config
		Resolved	ENHANCEMENT	jestabro	T5443 Add merge_defaults as Config method
		Resolved	ENHANCEMENT	jestabro	T6203 Remove obsoleted xml lib

Event Timeline

jestabro changed the task status from Open to In progress.Jun 22 2023, 1:40 PM

jestabro triaged this task as Normal priority.

jestabro created this task.

jestabro created this object in space S1 VyOS Public.

jestabro added a parent task: T5228: Simplify get_config_dict and add argument with_defaults.

PR:
https://github.com/vyos/vyos-1x/pull/2052

jestabro closed this task as Resolved.Jun 24 2023, 1:44 PM

jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.

pasik added a subscriber: pasik.Jun 25 2023, 2:31 PM

jestabro added a subtask: T5319: Remove remaining workarounds for incorrect defaults.Jun 28 2023, 3:17 PM

jestabro mentioned this in T5330: Keep track of source of config dict value when merging defaults.Jun 30 2023, 7:40 PM

jestabro closed subtask T5319: Remove remaining workarounds for incorrect defaults as Resolved.Aug 11 2023, 2:30 PM

jestabro mentioned this in T6203: Remove obsoleted xml lib.Thu, Apr 4, 7:57 PM