Removing interface from bridge results in error & config / system state mismatch
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	pers.edwin
	Jan 16 2018, 2:35 PM

Description

Hi,
Fresh install of 1.1.8 throws a perl error when attempting to remove an interface from a bridge-group. The interface is removed from the bridge, but the configuration isn't changed to reflect this, resulting in the interface being re-added at next reboot

vyos@vyos:~$ show bridge
bridge name     bridge id               STP enabled     interfaces
br0             0000.128a38ead978       no              eth1
vyos@vyos:~$ configure
[edit]
vyos@vyos# delete interfaces ethernet eth1 bridge-group bridge br0 
[edit]
vyos@vyos# commit
[ interfaces ethernet eth1 bridge-group ]
Use of uninitialized value $newbridge in string ne at /opt/vyatta/sbin/vyatta-bridge.pl line 88.
Use of uninitialized value $newbridge in concatenation (.) or string at /opt/vyatta/sbin/vyatta-bridge.pl line 89.
Moving interface eth1 from br0 to 
Use of uninitialized value $bridge in concatenation (.) or string at /opt/vyatta/sbin/vyatta-bridge.pl line 98.
Incorrect number of arguments for command
Usage: brctl addif <bridge> <device>    add interface to bridge

[[interfaces ethernet eth1]] failed
Commit failed

Steps to reproduce:

Create a bridge, brX, and add ethY to it
Commit, save, and exit from configure mode
Attempt to remove ethY from brX

See attached files for detailed output:

vyos.vyos.tech-support.2018-01-16-141446.txt212 KBDownload

delete-bridge-member.txt4 KBDownload

EDIT - sanitized show tech-support output, not enough coffee this morning

Details

Version: 1.1.8

Event Timeline

pers.edwin created this task.Jan 16 2018, 2:35 PM

pers.edwin updated the task description. (Show Details)Jan 16 2018, 2:58 PM

@pers.edwin does this happens on 1.2 too?

Nope, tested both the vrrp (999.201711150853) and frr (999.201711012230) builds with the same configuration commands as I ran on 1.1.8 and it drops the bridge member properly.

However, I do see that the parent bridge-group config remains with that interface after committing the config:

ethernet eth1 {
    bridge-group {
    }
}

...but that entry is removed after a reboot.

see attached for details

1.2.0_vrrp.txt3 KBDownload

1.2.0_frr.txt4 KBDownload

please retest on latest rolling

The bug, as stated, is not reproducible in rc1.

dmbaturin@vyos# set interfaces ethernet eth4 bridge-group bridge br0
[edit]
dmbaturin@vyos# commit
[ interfaces ethernet eth4 bridge-group ]
Adding interface eth4 to bridge br0

[edit]
dmbaturin@vyos# run show bridge 
bridge name     bridge id               STP enabled     interfaces
br0             8000.0050569b18ed       no              eth4
                                                        vtun10
[edit]
dmbaturin@vyos# delete interfaces ethernet eth4 bridge-group 
[edit]
dmbaturin@vyos# commit
[ interfaces ethernet eth4 bridge-group ]
Removing interface eth4 from bridge br0

[edit]
dmbaturin@vyos# run show bridge 
bridge name     bridge id               STP enabled     interfaces
br0             8000.868abd1c912d       no              vtun10

Perhaps it was fixed by some of the earlier commits. I'm closing the task.

dmbaturin moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc3) board.Oct 15 2018, 1:09 PM

syncer added a project: VyOS-1.2.0-GA.Oct 15 2018, 10:17 PM

	F31044: vyos.vyos.tech-support.2018-01-16-141446.txt
	Jan 16 2018, 2:58 PM

	F31041: vyos.vyos.tech-support.2018-01-16-141446.txt
	Jan 16 2018, 2:35 PM

	F34267: 1.2.0_vrrp.txt
	Mar 7 2018, 2:02 PM

	F34266: 1.2.0_frr.txt
	Mar 7 2018, 2:02 PM

Removing interface from bridge results in error & config / system state mismatchClosed, ResolvedPublicBUGActions

Description

Details

Event Timeline

Removing interface from bridge results in error & config / system state mismatch
Closed, ResolvedPublicBUG
Actions