Page MenuHomeVyOS Platform
Create Task
Maniphest T4957

config-mgmt should not attempt to archive config at boot
Closed, ResolvedPublicBUG
Actions

Description

The following fixes potential bugs and restores behavior of the legacy package that were dropped in translation:

(1) priority was not set in the interface-definition when porting from vyatta-config-mgmt
(2) as in the legacy package, one should upload to commit archive based on effective_value, not proposed value; this avoids possible failure at boot

Adopting (2), the value we set for priority is not as critical, so we set it as it was in legacy: '400'.

Details

Version
vyos-1.4
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

StatusSubtypeAssignedTask
 In progressFEATURE REQUESTNoneT3355 Remove all remaining legacy Vyatta code
 ResolvedFEATURE REQUESTjestabroT4942 Rewrite vyatta-config-mgmt to Python/XML
 ResolvedBUGjestabroT4957 config-mgmt should not attempt to archive config at boot

Event Timeline

jestabro created this task.Jan 26 2023, 2:20 AM
jestabro triaged this task as High priority.
jestabro created this object in space S1 VyOS Public.
jestabro added a parent task: T4942: Rewrite vyatta-config-mgmt to Python/XML.
jestabro mentioned this in rVYOSONEX55d83a1f138d: config-mgmt: T4957: set priority.Jan 26 2023, 2:23 AM
jestabro mentioned this in rVYOSONEXb1d2bb907c53: config-mgmt: T4957: upload to archive only for location effective_values.
jestabro closed this task as Resolved.Jan 26 2023, 2:25 AM
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
pasik subscribed.Jan 26 2023, 10:11 AM
Restricted Repository Identity mentioned this in rVYOSONEX7721e43e8b68: Merge pull request #2504 from c-po/commit-archive-help.Nov 19 2023, 1:51 AM
c-po mentioned this in rVYOSONEXdcb277ba0aed: config-mgmt: T4957: T2405: add proper valueHelp strings for remote URL.Nov 19 2023, 1:51 AM
c-po mentioned this in rVYOSONEXde79af2621c1: config-mgmt: T4957: T2405: add proper valueHelp strings for remote URL.Nov 19 2023, 8:15 AM
c-po mentioned this in rVYOSONEXe6c1f1ed512e: config-mgmt: T4957: T2405: add proper valueHelp strings for remote URL.Nov 19 2023, 8:18 AM
c-po mentioned this in rVYOSONEXe92667504e0c: config-mgmt: T4957: remove TFTP user/pass from completion helper.Nov 19 2023, 9:20 PM
c-po mentioned this in rVYOSONEXd87dfa557c96: config-mgmt: T4957: remove TFTP user/pass from completion helper.