Migrate the file-exists validator away from Python
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dmbaturin
	Nov 4 2022, 3:26 PM

Description

Using Python for validators turned out a bad idea to to the python interpreter startup cost. File existence check is common so it's a big source of performance issues.

Details

Version: -
Is it a breaking change?: Perfectly compatible
Issue type: Performance optimization

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	FEATURE REQUEST	dmbaturin	T4795 Cleanup custom python validators
		Resolved		dmbaturin	T4798 Migrate the file-exists validator away from Python

Event Timeline

dmbaturin created this task.Nov 4 2022, 3:26 PM

dmbaturin added a project: VyOS 1.3 Equuleus (1.3.3).

jestabro added a parent task: T4795: Cleanup custom python validators.Nov 4 2022, 3:54 PM

pasik subscribed.Nov 4 2022, 5:14 PM

Restricted Repository Identity mentioned this in rVYOSONEX92aa324fef80: Merge pull request #1706 from jestabro/validator-file-exists.Dec 14 2022, 3:07 PM

jestabro mentioned this in rVYOSONEX046bb9ccd56a: validators: T4798: replace python file-exists validator with file-path.Dec 14 2022, 3:07 PM

jestabro closed this task as Unknown Status.Dec 14 2022, 3:09 PM

jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.3) board.Jan 22 2023, 7:33 AM

Backport PR for VyOS 1.3 https://github.com/vyos/vyos-1x/pull/1774

c-po mentioned this in rVYOSONEXddd2a3e01b2f: validators: T4798: replace python file-exists validator with file-path.Jan 22 2023, 5:53 PM

c-po changed the task status from Unknown Status to Resolved.Jan 23 2023, 7:16 AM

dmbaturin mentioned this in 1.3.3.May 19 2023, 1:04 PM

Migrate the file-exists validator away from PythonClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Migrate the file-exists validator away from Python
Closed, ResolvedPublic
Actions

Related Objects
Search...