Page MenuHomeVyOS Platform
Create Task
Maniphest T4669

Extend numeric.ml for inversion of values and range values
Closed, ResolvedPublicENHANCEMENT
Actions

Description

This task will provide two requested extensions to numeric.ml:

(1) allow passing an interval value to --range:
numeric --range 0-10 2-5 (passes)
numeric --range 0-10 7-12 (fails)

(2) define an inversion operator for --range:
numeric --range 0-10 !12 (passes)
numeric --range 0-10 !5 (fails)

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Related Objects
Search...

Event Timeline

jestabro changed the task status from Open to In progress.Sep 3 2022, 12:37 PM
jestabro triaged this task as Normal priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro added a comment.Sep 3 2022, 12:47 PM

Initial draft; suggested changes and testing to follow:

https://github.com/vyos/vyos-utils/pull/5

jestabro added a comment.Sep 6 2022, 1:52 PM

Changes for the inversion operator (--not-range instead of !) have been made. Generalizing exit codes, as suggested in PR comments will be handled in a separate task.

pasik added a subscriber: pasik.Sep 6 2022, 2:25 PM
jestabro changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.Sep 7 2022, 3:35 PM
jestabro changed Issue type from Unspecified (please specify) to Improvement (missing useful functionality).
c-po closed this task as Resolved.Sep 16 2022, 6:37 AM
c-po mentioned this in T4698: Drop validator name="range" and replace it with numeric.
c-po removed a project: VyOS 1.3 Equuleus (1.3.3).
c-po closed subtask T4698: Drop validator name="range" and replace it with numeric as Resolved.Sep 16 2022, 7:16 AM