route-map does not support ipv6 peer
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	aderouineau
	Jun 21 2022, 2:00 AM

Description

VyOS 1.3 does not support matching an ipv6 peer even though, FRR 7.5.1 (which is bundled with VyOS 1.3) supports it:

Working example accessing FRR directly through vtysh:

route-map test permit 1
 match peer fe80::2

Error from VyOS configuration:

# set policy route-map test rule 1 match peer fe80::2

  peer must be either an IP or local
  Value validation failed
  Set failed

I believe the change is a matter of adding an ipv6-address validator to https://github.com/vyos/vyos-1x/blob/current/interface-definitions/policy.xml.in#L957

Details

Difficulty level: Easy (less than an hour)
Version: 1.3.1-S1 , 1.4
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Perfectly compatible
Issue type: Improvement (missing useful functionality)

Related Objects

Mentioned In: 1.3.4

Event Timeline

aderouineau created this task.Jun 21 2022, 2:00 AM

n.fort claimed this task.Jun 21 2022, 3:20 PM

pasik added a subscriber: pasik.Jun 21 2022, 4:25 PM

PR for 1.4: https://github.com/vyos/vyos-1x/pull/1367

Viacheslav changed the task status from In progress to Needs testing.Jun 28 2022, 3:20 PM

@n.fort Could you create PR for 1.3?
I think it should be here https://github.com/vyos/vyatta-cfg-quagga/blob/d4097690c40f619bc0e78a0d674985f7880a19a3/templates/policy/route-map/node.tag/rule/node.tag/match/peer/node.def#L3-L4

Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.Jul 20 2022, 4:32 PM

Modyfing file pointed by @Viacheslav , makes ipv6 peer option available.
But while testing config, it's not possible to insert an ipv6 address: validator rejects input.
Validator used: syntax:expression: exec "/opt/vyatta/sbin/vyatta-policy.pl --check-peer-syntax $VAR(@)"; "peer must be either an IP or local"

That validator can be found here: https://github.com/vyos/vyatta-cfg-quagga/blob/d4097690c40f619bc0e78a0d674985f7880a19a3/scripts/policy/vyatta-policy.pl#L42-L49, but it only validates ipv4 address

n.fort removed n.fort as the assignee of this task.Jul 20 2022, 5:16 PM

n.fort added a subscriber: n.fort.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.2); removed VyOS 1.4 Sagitta, VyOS 1.3 Equuleus.Aug 14 2022, 1:05 PM

dmbaturin edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.2).Aug 14 2022, 6:00 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:46 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM

PR for 1.3.4 https://github.com/vyos/vyatta-cfg-quagga/pull/101

Viacheslav closed this task as Resolved.Aug 30 2023, 4:16 PM

Viacheslav claimed this task.

Viacheslav edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.5).

Viacheslav moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.4) board.