Page MenuHomeVyOS Platform
Create Task
Maniphest T4468

web-proxy source group cannot start with a number bug
Closed, ResolvedPublicBUG
Actions

Description

When trying to create webproxy squidguard source group i'm getting error:
vyos@fw-01# set service webproxy url-filtering squidguard source-group app

URL-filter source-group cannot start with a number!
Value validation failed
Set failed

Currently validation accepts only single letter for the name of the source group:
vyos@fw-01# set service webproxy url-filtering squidguard source-group a
[edit]
vyos@fw-01#

Details

Version
1.4 (all current rolling releases of 1.4 that I've tried)
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

Nova_Logic created this task.Jun 16 2022, 7:49 AM
Viacheslav subscribed.Jun 16 2022, 8:08 AM

It seems issue with this validator https://github.com/vyos/vyos-1x/blob/1978946312a36f4913e1e5ea7754668b1c653d09/interface-definitions/service_webproxy.xml.in#L487

Viacheslav changed the task status from Open to In progress.Jun 16 2022, 8:37 AM
Viacheslav claimed this task.
Viacheslav added a comment.Jun 16 2022, 8:41 AM

PR https://github.com/vyos/vyos-1x/pull/1363

vyos@r14# set service webproxy url-filtering squidguard source-group fdsf-dg
[edit]
vyos@r14#
Restricted Repository Identity mentioned this in rVYOSONEXfc5c0d5975a0: Merge pull request #1363 from sever-sever/T4468.Jun 16 2022, 8:55 AM
Viacheslav mentioned this in rVYOSONEXfbd3bef2248d: webproxy: T4468: Fix regex for squidguard source-group.Jun 16 2022, 8:55 AM
Viacheslav added a project: VyOS 1.3 Equuleus (1.3.2).Jun 16 2022, 8:57 AM
Viacheslav added a comment.Jun 16 2022, 9:11 AM

PR for 1.3 https://github.com/vyos/vyos-1x/pull/1364

Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Jun 16 2022, 9:11 AM
pasik subscribed.Jun 16 2022, 3:49 PM
Restricted Repository Identity mentioned this in rVYOSONEX464af891335e: Merge pull request #1364 from sever-sever/T4468-eq.Jul 9 2022, 10:13 AM
Viacheslav mentioned this in rVYOSONEX5cba52312bcf: webproxy: T4468: Fix regex for squidguard source-group.Jul 9 2022, 10:13 AM
Viacheslav closed this task as Resolved.Jul 9 2022, 10:26 AM
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.2) board.
dmbaturin mentioned this in 1.3.2.Sep 5 2022, 3:14 PM
dmbaturin mentioned this in 1.3.2.Sep 15 2022, 10:42 AM