Maniphest T3740

HTTPs API breaks when the address is IPv6
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	kroy
	Aug 11 2021, 6:41 PM

Tags

Referenced Files

None

Subscribers

Description

https://github.com/vyos/vyos-1x/blob/82fbacd13f852374df2ecdd394b983325445f81b/data/templates/https/nginx.default.tmpl#L20

That line needs conditional brackets when the address is IPv6

Details

Difficulty level: Easy (less than an hour)
Version: rolling
Why the issue appeared?: Implementation mistake
Is it a breaking change?: Perfectly compatible
Issue type: Bug (incorrect behavior)

Event Timeline

kroy created this task.Aug 11 2021, 6:41 PM

jestabro claimed this task.Aug 11 2021, 6:46 PM

c-po added projects: test, VyOS 1.3 Equuleus.Aug 13 2021, 10:32 AM

c-po closed this task as Resolved.Aug 13 2021, 10:35 AM

c-po claimed this task.

c-po triaged this task as Normal priority.

c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.

c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.

c-po added a subscriber: jestabro.

pasik added a subscriber: pasik.Aug 13 2021, 11:43 AM

SrividyaA set Issue type to Bug (incorrect behavior).Sep 1 2021, 10:48 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed VyOS 1.3 Equuleus, test.Sep 5 2021, 7:06 AM

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0-epa1) board.Sep 5 2021, 4:07 PM

c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.Sep 19 2021, 7:05 AM