Page MenuHomeVyOS Platform

vyos-1x build include not all nodes
Closed, ResolvedPublicBUG

Description

Not all nodes included in vyos-1x after build. Possible some bug with Jenkins EC2.

For example, after build we don't see "metric-type" for some protocols

Expected

vyos@r5-roll# set protocols ospf redistribute isis 
Possible completions:
   metric       OSPF default metric
   metric-type  OSPF metric type for default routes (default: 2)
   route-map    Route map reference

Getting after building in the doker.

debuild -us -uc -b

We can see "metric-type" for bgp and connected

vyos_bld@a8712e3885ae:/vyos/work/test/vyos-1x$ cat build/interface-definitions/protocols-ospf.xml | grep "name=\"bgp\"" -A 25
    <node name="bgp">
      <properties>
        <help>Redistribute BGP routes</help>
      </properties>
      <children>
<!-- include start from ospf/ospf-metric.xml.i -->
<leafNode name="metric">
  <properties>
    <help>OSPF default metric</help>
    <valueHelp>
      <format>u32:0-16777214</format>
      <description>Default metric</description>
    </valueHelp>
    <constraint>
      <validator name="numeric" argument="--range 0-16777214"/>
    </constraint>
  </properties>
</leafNode>
<!-- include end -->
<!-- include start from ospf/ospf-metric-type.xml.i -->   
<leafNode name="metric-type">          <======== CORRECT INCLUDE ========== 
  <properties>
    <help>OSPF metric type for default routes (default: 2)</help>
    <valueHelp>
      <format>u32:1-2</format>
      <description>Metric type for default routes</description>

But for redistribute isis and rip we don't see such node in include.

vyos_bld@a8712e3885ae:/vyos/work/test/vyos-1x$ cat build/interface-definitions/protocols-ospf.xml | grep "name=\"isis\"" -A 25
    <node name="isis">
      <properties>
        <help>Redistribute IS-IS routes</help>
      </properties>
      <children>
<!-- include start from ospf/ospf-metric.xml.i -->
<leafNode name="metric">
  <properties>
    <help>OSPF default metric</help>
    <valueHelp>
      <format>u32:0-16777214</format>
      <description>Default metric</description>
    </valueHelp>
    <constraint>
      <validator name="numeric" argument="--range 0-16777214"/>
    </constraint>
  </properties>
</leafNode>
<!-- include end -->
<!-- include start from ospf/ospf-metric-type.xml.i -->   <======= EMPTY XML INCLUDE ===========
<!-- include end -->
<!-- include start from route-map.xml.i -->
<leafNode name="route-map">
  <properties>
    <help>Route map reference</help>
    <valueHelp>

It generate empty xml
<!-- include start from ospf/ospf-metric-type.xml.i -->
<!-- include end -->

Details

Difficulty level
Easy (less than an hour)
Version
1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Includes
https://github.com/vyos/vyos-1x/blob/current/interface-definitions/include/ospf/ospf-common-config.xml.i#L619-L678

Expect

vyos@r5-roll# set protocols ospf redistribute isis 
Possible completions:
   metric       OSPF default metric
   metric-type  OSPF metric type for default routes (default: 2)
   route-map    Route map reference

Get

vyos@r5-roll# set protocols ospf redistribute isis 
Possible completions:
   metric       OSPF default metric
   route-map    Route map reference
jestabro changed the task status from Open to Needs testing.Mar 31 2021, 4:55 PM
jestabro triaged this task as High priority.
jestabro changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
jestabro moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.
jestabro moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
SrividyaA set Issue type to Bug (incorrect behavior).Aug 31 2021, 5:38 PM