Page MenuHomeVyOS Platform
Create Task
Maniphest T3284

merge/load fail silently if unable to resolve host
Closed, ResolvedPublicBUG
Actions

Description

The config mode commands 'merge' and 'load' will fail silently if passed a remote config file location whose hostname is unresolved.

Details

Version
vyos-1.4
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

jestabro created this task.Feb 3 2021, 7:56 PM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro added a comment.Mar 12 2021, 5:20 PM

Assuming T3356 can be backported to equuleus, this fix will not be needed.

pasik subscribed.Mar 12 2021, 6:25 PM
erkin claimed this task.Mar 15 2021, 6:58 AM
erkin subscribed.

I'll give backporting a try. It should be doable as long as Paramiko is in our reach. If not, I'll see if I can cobble together something to check for hostname resolution failure.

jestabro added a comment.Mar 15 2021, 1:24 PM

Thanks, @erkin --- I'm sure you can cherry-pick from 1.4 to 1.3; 'backporting' is not quite the right word, as it is development branch to stable branch. I really like this solution to the mess that was remote.py.

Restricted Repository Identity mentioned this in rVYOSONEXb9f83a1b21c7: Merge pull request #782 from erkin/equuleus.Mar 22 2021, 1:03 PM
erkin mentioned this in rVYOSONEXe7545f9d482e: T3284: Merge Paramiko-based remote.py implementation.Mar 22 2021, 1:03 PM
jestabro closed this task as Resolved.Mar 22 2021, 1:09 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
Restricted Repository Identity mentioned this in rVYOSONEXf2633dcbdbf1: Merge pull request #795 from erkin/equuleus.Mar 30 2021, 3:34 PM
SrividyaA set Issue type to Bug (incorrect behavior).Aug 30 2021, 6:23 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:17 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.