Page MenuHomeVyOS Platform
Create Task
Maniphest T3072

Migrate tunnel interfaces to new get_config_dict() approach
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Migrate the existing tunnel interface Python/XML implementation to re-use the new vyos.ifconfig.interface.update() logic.

Tunnel is the second to last interface which does not make use of this backend functionality - it's time to change this.

Migrating the code transforms the tunnel code into a true object-oriented model as ~90% of the code can be reused which gives us more or less a single-source of truth.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

Event Timeline

c-po created this task.Nov 15 2020, 9:32 AM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Low priority.
c-po added a subtask: T2966: tunnel: add new encapsulation types ip6tnl and ip6gretap.
c-po edited a custom field.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.Nov 15 2020, 10:26 AM
c-po added a subtask: T3068: Automatic generation of IPv6 link local addresses for tunnel interfaces.Nov 20 2020, 11:28 AM
c-po mentioned this in rVYOSONEXd98e01da6b18: tunnel: T3072: migrate to get_config_dict().Nov 20 2020, 11:56 AM
c-po mentioned this in rVYOSONEX246808bc33a2: tunnel: T3072: xml: harden regex validators.
c-po mentioned this in rVYOSONEX4eef27f0e834: tunnel: T3072: interfaces used for NHRP can not be deleted.
c-po mentioned this in rVYOSONEX7ad026794bee: Merge branch 'tunnel-rewrite' into current.
c-po closed this task as Resolved.Nov 20 2020, 11:57 AM
c-po closed subtask T3068: Automatic generation of IPv6 link local addresses for tunnel interfaces as Resolved.
c-po mentioned this in rVYOSONEXfe8d884b564e: tunnel: T3072: support changing tunnel encapsulation on-the-fly.Nov 20 2020, 1:42 PM
c-po mentioned this in rVYOSONEX3ae4de269951: tunnel: T3072: drop dead code.
c-po mentioned this in rVYOSONEXca073ba863b5: tunnel: T3072: bugfix KeyError for IPv6 GRE verify code.Nov 20 2020, 3:47 PM
c-po mentioned this in rVYOSONEX7fce006670bf: tunnel: T3072: remove debug print code.
c-po moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.Nov 23 2020, 4:04 PM
c-po mentioned this in rVYOSONEXa223e169b099: tunnel: T3072: 'gre' devices do not support bridging.Nov 23 2020, 4:08 PM
c-po mentioned this in rVYOSONEX64d6e689a827: tunnel: T3072: remove bridgable variable as this is already set by the base….Nov 26 2020, 4:16 PM
c-po mentioned this in rVYOSONEXe81c0134e596: tunnel: T3072: remove duplicate key from mapping dict used in apply().Feb 22 2021, 5:50 PM
c-po mentioned this in rVYOSONEX09b1b533d14e: tunnel: T3072: remove duplicate key from mapping dict used in apply().
c-po changed the status of subtask T3364: tunnel: cleanup/rename CLI nodes from Open to In progress.Feb 27 2021, 8:09 AM
c-po closed subtask T3364: tunnel: cleanup/rename CLI nodes as Resolved.Feb 27 2021, 11:57 PM
c-po closed subtask T2966: tunnel: add new encapsulation types ip6tnl and ip6gretap as Resolved.Mar 3 2021, 8:37 PM
erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 12:15 PM
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.