Page MenuHomeVyOS Platform
Create Task
Maniphest T2953

Accel-PPP services CLI config cleanup (SSTP, L2TP, PPPoE, IPoE)
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Before converting services CLI config to get_config_dict() and reuse already present templating - and probably tests (after T2936 was migrated) - the CLI should be streamlined to match the PPPoE implementation.

The difference is, one side calls it ppp-options, the other calls the CLI node ppp-settings. Both perform the same stuff but under different nodes - which won't work when using get_config_dict().

Catch-all task for all Accel-PPP service CLI migrations

  • PPPoE
    • rename local-ip to gateway-address
  • SSTP
    • move network-settings gateway-address to gateway-address
    • move network-settings client-ip-settings to client-ip-pool
    • move network-settings name-server to name-server
    • move network-settings mtu to mtu
    • drop network-settings node

Details

Version
-
Is it a breaking change?
Config syntax change (migratable)
Issue type
Feature (new functionality)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFEATURE REQUESTc-poT2953 Accel-PPP services CLI config cleanup (SSTP, L2TP, PPPoE, IPoE)
 ResolvedFEATURE REQUESTc-poT2960 sstp: migrate to get_config_dict()

Event Timeline

c-po created this task.Oct 2 2020, 3:38 PM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po edited a custom field.
c-po mentioned this in rVYOSONEXba0509379c5c: acces-ppp: T2953: drop redundant CLI definitions.Oct 2 2020, 3:43 PM
c-po mentioned this in rVYOSONEXcbdbbdceaad5: sstp: T2953: migrate ppp-settings to ppp-options node.Oct 2 2020, 3:52 PM
c-po closed this task as Resolved.Oct 2 2020, 3:55 PM
c-po triaged this task as Normal priority.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Config syntax change (migratable).
c-po mentioned this in rVYOSONEX7e8b1299e6e1: accel-ppp: T2953: fix missing defaultValue on mppe.Oct 3 2020, 8:10 AM
c-po mentioned this in rVYOSONEX2c90c0d7c8d3: sstp: T2953: migrate name-server settions to common level.Oct 3 2020, 5:59 PM
c-po mentioned this in rVYOSONEX585aaf9c5770: sstp: T2953: migrate mtu to common level.Oct 3 2020, 6:44 PM
c-po renamed this task from SSTP CLI config cleanup to Accel-PPP services CLI config cleanup (SSTP, L2TP, PPPoE, IPoE).Oct 4 2020, 8:53 AM
c-po reopened this task as In progress.
c-po updated the task description. (Show Details)
c-po edited a custom field.
c-po updated the task description. (Show Details)
c-po updated the task description. (Show Details)Oct 4 2020, 8:56 AM
c-po updated the task description. (Show Details)Oct 4 2020, 9:37 AM
c-po mentioned this in rVYOSONEX4649284812bb: sstp: T2953: migrate gateway-address, client-ip-settings to common level.Oct 4 2020, 9:40 AM
c-po mentioned this in rVYOSONEXf4e9248d2a24: pppoe-server: T2953: rename CLI local-ip to gateway-address.Oct 4 2020, 10:12 AM
c-po closed this task as Resolved.Oct 4 2020, 10:33 AM
c-po mentioned this in rVYOSONEXdd833b361dd7: l2tp: pptp: sstp: pppoe-server: T2953: use common include for client-ip-pool.Oct 4 2020, 10:34 AM
c-po mentioned this in rVYOSONEX25c8e1609b59: l2tp: pptp: pppoe-server: T2953: use common Accel-PPP MTU include file.
pasik subscribed.Oct 4 2020, 5:33 PM
c-po closed subtask T2960: sstp: migrate to get_config_dict() as Resolved.Oct 4 2020, 5:47 PM
c-po mentioned this in rVYOSONEX136d81c13c79: pppoe-server: T2953: prepare common chap-secrets file.Oct 4 2020, 5:47 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 23 2020, 3:26 PM
erkin set Issue type to improvement.Aug 29 2021, 12:44 PM
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:27 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
dmbaturin set Issue type to Feature (new functionality).Nov 8 2024, 10:49 AM