Page MenuHomeVyOS Platform
Create Task
Maniphest T2953

Accel-PPP services CLI config cleanup (SSTP, L2TP, PPPoE, IPoE)
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Before converting services CLI config to get_config_dict() and reuse already present templating - and probably tests (after T2936 was migrated) - the CLI should be streamlined to match the PPPoE implementation.

The difference is, one side calls it ppp-options, the other calls the CLI node ppp-settings. Both perform the same stuff but under different nodes - which won't work when using get_config_dict().

Catch-all task for all Accel-PPP service CLI migrations

  • PPPoE
    • rename local-ip to gateway-address
  • SSTP
    • move network-settings gateway-address to gateway-address
    • move network-settings client-ip-settings to client-ip-pool
    • move network-settings name-server to name-server
    • move network-settings mtu to mtu
    • drop network-settings node

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Improvement (missing useful functionality)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFEATURE REQUESTc-poT2953 Accel-PPP services CLI config cleanup (SSTP, L2TP, PPPoE, IPoE)
 ResolvedFEATURE REQUESTc-poT2960 sstp: migrate to get_config_dict()

Event Timeline

c-po changed the task status from Open to In progress.Oct 2 2020, 3:38 PM
c-po claimed this task.
c-po created this task.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po closed this task as Resolved.Oct 2 2020, 3:55 PM
c-po triaged this task as Normal priority.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Config syntax change (migratable).
c-po renamed this task from SSTP CLI config cleanup to Accel-PPP services CLI config cleanup (SSTP, L2TP, PPPoE, IPoE).Oct 4 2020, 8:53 AM
c-po reopened this task as In progress.
c-po updated the task description. (Show Details)
c-po changed Difficulty level from Easy (less than an hour) to Normal (likely a few hours).
c-po updated the task description. (Show Details)
c-po updated the task description. (Show Details)Oct 4 2020, 8:56 AM
c-po updated the task description. (Show Details)Oct 4 2020, 9:37 AM
c-po closed this task as Resolved.Oct 4 2020, 10:33 AM
pasik added a subscriber: pasik.Oct 4 2020, 5:33 PM
c-po closed subtask T2960: sstp: migrate to get_config_dict() as Resolved.Oct 4 2020, 5:47 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 23 2020, 3:26 PM
erkin set Issue type to Improvement (missing useful functionality).Aug 29 2021, 12:44 PM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:27 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.