Page MenuHomeVyOS Platform
Create Task
Maniphest T2644

Bonding interfaces cannot be disabled
Closed, ResolvedPublic
Actions

Description

Disabling bonded interfaces is broken:

trae@cr01b-vyos# show interfaces bonding bond2
 address dhcp
 description "DL: L::cr01b-vyos.int bond2 | R::ir01.int Po1.21 (FIOS)"
 hash-policy layer3+4
 member {
     interface eth4
     interface eth5
 }
 mode xor-hash
 vrf FIOS
trae@cr01b-vyos# set interfaces bonding bond2 disable
[edit]
trae@cr01b-vyos# commit
Using source address fd52:d62e:8011:6e:192:168:15:4
[edit]
trae@cr01b-vyos# run show interfaces bonding bond2 brief 
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
bond2            -                                 u/u  DL: L::cr01b-vyos.int
                                                        DL: L::cr01b-vyos.int |
                                                        DL: L::cr01b-vyos.int |
                                                        DL: L::cr01b-vyos.int |
                                                        DL: L::cr01b-vyos.int |
[edit]

Details

Version
1.3-rolling-202006241940
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

StatusSubtypeAssignedTask
 In progressFEATURE REQUESTNoneT3355 Remove all remaining legacy Vyatta code
 ResolvedFEATURE REQUESTNoneT1579 Rewrite all interface types in new XML/Python style
 ResolvedFEATURE REQUESTc-poT2653 "set interfaces" Python handler code improvements - next iteration
 Resolvedc-poT2644 Bonding interfaces cannot be disabled

Event Timeline

trae32566 created this task.Jun 25 2020, 2:56 AM
trae32566 created this object in space S1 VyOS Public.
trae32566 added a comment.Jul 8 2020, 7:59 PM

Can regression testing of some sort be added for this? I've seen this issue crop up before now, so I would guess this is a good candidate for that if possible.

c-po subscribed.Jul 8 2020, 8:02 PM

There is a basic test for this which should be expanded.

https://github.com/vyos/vyos-smoketest/blob/master/scripts/cli/test_interfaces_bonding.py

pasik subscribed.Jul 9 2020, 6:25 AM
Viacheslav subscribed.EditedJul 21 2020, 1:07 PM

The problem not in the bonding.
Any interface with DHCP address can't be disabled.

vyos@r-roll:~$ show conf com | match eth1
set interfaces ethernet eth1 address 'dhcp'
set interfaces ethernet eth1 disable
vyos@r-roll:~$ show int
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
eth1             192.168.100.227/24                u/u

https://phabricator.vyos.net/T2163

c-po added a comment.Jul 21 2020, 2:24 PM

Must be fixed after T2653 - then there is only a single truth for all interfaces

c-po added a parent task: T2653: "set interfaces" Python handler code improvements - next iteration.Jul 21 2020, 2:24 PM
c-po added a comment.Jul 26 2020, 1:10 PM

Works as expected in latest rolling: 1.3-rolling-20200724

75: bond0: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noqueue state DOWN group default qlen 1000
    link/ether 00:50:56:bf:ef:aa brd ff:ff:ff:ff:ff:ff
c-po closed this task as Resolved.Jul 26 2020, 1:10 PM
c-po claimed this task.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Aug 3 2020, 2:13 PM
erkin renamed this task from Disabling Bonded Interfaces Broken to Bonding interfaces cannot be disabled.Aug 29 2021, 2:07 PM
erkin set Issue type to Unspecified (please specify).
erkin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 7:13 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.