Page MenuHomeVyOS Platform
Create Task
Maniphest T2488

Remove logfile for dialup interfaces like pppoe and wwan
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

There is no "real reason" for a dedicated logfile as everything is logged to journald/syslog

Also the logfile caused more harm (permissions) in the past then it was good for.

Drop the op-mode commands

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)

Related Objects

Event Timeline

c-po created this task.May 21 2020, 4:42 PM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po mentioned this in rVYOSONEXe7ebf1c54c26: pppoe: wwan: T2488: drop individual ppp logs.May 21 2020, 4:45 PM
c-po closed this task as Resolved.May 21 2020, 5:05 PM
c-po mentioned this in rVYOSONEX39c53aadbf9e: pppoe: T2488: remove logfile generation.May 21 2020, 5:06 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:21 PM
c-po mentioned this in rVYOSONEXfee52f5add71: pppoe: T2488: bugfix, missing not in if condition prevented startup.May 22 2020, 9:39 AM
pasik subscribed.May 22 2020, 12:15 PM
njh subscribed.May 24 2020, 9:12 AM

Just found this ticket after upgrading and wondering where the show interfaces pppoe pppoe0 log command had gone. I did find it useful to check why a PPPoE interface hadn't come up.

Is documentation included in your definition of done? Or should it be a different ticket?

https://docs.vyos.io/en/latest/interfaces/pppoe.html#opcmd-show-interfaces-pppoe-interface-log

Is it possible to get the log lines just for a single interface from syslog? (other than grep)

c-po added a comment.EditedMay 24 2020, 10:31 AM

The "auto grep" could be added to show log indeed that it only displays you pppoe stuff.

Main reason was to remove the "double log" once to systemd/journald/syslog and then to a dedicated logfile in addition.

c-po added a comment.EditedJun 7 2020, 12:25 PM

@njh you have been right that command can be quiet handy, but instead of using a logfile we query "journalctl" for the appropriate logs.

vyos@vyos:~$ show interfaces pppoe pppoe0 log
-- Logs begin at Sun 2020-06-07 11:59:03 CEST, end at Sun 2020-06-07 14:28:39 CEST. --
-- No entries --
njh added a comment.Jun 7 2020, 12:36 PM

Ah, nice! I will update to the rolling release and give it is go soon.

c-po added a comment.Jun 7 2020, 12:38 PM

It will be in the next rolling (any rolling newer then vyos-1.3-rolling-202006070117-amd64.iso)

c-po mentioned this in rVYOSONEXd70f1538f215: wwan: T2488: remove generation of dedicated logfile.Jun 7 2020, 3:10 PM
c-po mentioned this in rVYOSONEX561694378e11: wwan: op-mode: T2488: retrieve log info from journalctl.
c-po mentioned this in rVYOSONEX52d8a2265ef7: pppoe: op-mode: T2488: retrieve log info from journalctl.
c-po mentioned this in rVYOSONEX6179a89fd4c1: Merge branch 'udev' of github.com:c-po/vyos-1x into current.
c-po mentioned this in rVYOSONEXf583fa94ba00: wwan: pppoe: op-mode: T2488: only call pppstats when interface is up.Aug 2 2020, 4:25 PM
c-po mentioned this in rVYOSONEX8417f5513597: Revert "pppoe: do not check manually if pppoe process runs".Aug 27 2020, 7:14 PM
erkin set Issue type to improvement.Aug 30 2021, 6:06 AM
erkin removed a subscriber: Global Notifications.
c-po mentioned this in rVYOSONEX97eb86c4866d: dns: op-mode: T2488: retrieve log info from journalctl.Jul 7 2022, 10:38 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:02 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
c-po mentioned this in rVYOSONEXa7fba75a06ef: dns: op-mode: T2488: drop invalid "monitor dns forwarding" command.Aug 30 2022, 3:38 PM
dmbaturin set Issue type to Feature (new functionality).Nov 8 2024, 10:48 AM