Page MenuHomeVyOS Platform
Create Task
Maniphest T2427

Interface addressing broken since fix for T2372 was merged
Closed, ResolvedPublic
Actions

Description

After T2372 fix was merged (https://github.com/vyos/vyos-1x/pull/383), IPv6 EUI-64 addressing was broken, interfaces got assigned 'fe80::/64' when they shouldn't have, when interfaces got disabled their addresses got deleted from the interface so services that checked them failed to commit (eg dhcp-server).

Fix is in progress:

  • revert to old behavior of just putting interface to admin down when disabled without deleting addresses
  • fix bug where the default return value of a function was a list that got assigned by reference and not copied so changing one list variable changed also other unrelated variables
  • migrate vif, vif_s and vif_c variables from lists to dicts with VLAN IDs as keys and VLAN configs as values

Details

Version
1.3-rolling-202005040117
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

jjakob created this task.May 5 2020, 1:25 PM
jjakob changed the task status from Open to In progress.
jjakob triaged this task as Urgent! priority.
jjakob created this object in space S1 VyOS Public.
jjakob added a comment.May 5 2020, 3:27 PM

https://github.com/vyos/vyos-1x/pull/393

pasik subscribed.May 5 2020, 8:14 PM
Restricted Repository Identity mentioned this in rVYOSONEX57f905a70029: Merge pull request #393 from jjakob/disable-address-fix-T2427.May 6 2020, 7:58 AM
jjakob mentioned this in T2429: Vyos cannot apply VLAN sub interface to bridge.May 6 2020, 11:11 AM
jjakob added a comment.May 7 2020, 11:29 AM
03:42:04  DEBUG - Traceback (most recent call last):
03:42:04  DEBUG -   File "/usr/libexec/vyos/conf_mode/interfaces-wireless.py", line 810, in <module>
03:42:04  DEBUG -     verify(c)
03:42:04  DEBUG -   File "/usr/libexec/vyos/conf_mode/interfaces-wireless.py", line 621, in verify
03:42:04  DEBUG -     verify_vlan_config(wifi)
03:42:04  DEBUG -   File "/usr/lib/python3/dist-packages/vyos/ifconfig_vlan.py", line 155, in verify_vlan_config
03:42:04  DEBUG -     for vif in config['vif'].values():
03:42:04  DEBUG - AttributeError: 'list' object has no attribute 'values'
03:42:04  DEBUG - 
03:42:04  DEBUG - 
03:42:04  DEBUG - 
03:42:04  DEBUG - [[interfaces wireless wlan10]] failed
03:42:04  DEBUG - Commit failed

Forgot to migrate other interfaces to use the new functions. Will prepare a new PR.

jjakob added a comment.May 7 2020, 6:04 PM

https://github.com/vyos/vyos-1x/pull/399

Restricted Repository Identity mentioned this in rVYOSONEXa6a9602551e8: Merge pull request #399 from jjakob/disable-address-fix-T2427.May 8 2020, 4:39 PM
jjakob closed this task as Resolved.May 9 2020, 9:02 AM
jjakob moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
c-po mentioned this in rVYOSONEXb66b886e840f: validate: ipv6: mtu: T2427: wireless interface MTU is not configurable.Oct 5 2020, 5:35 PM
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 6:20 AM
erkin removed a subscriber: Global Notifications.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:02 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.