Page MenuHomeVyOS Platform

Interface addressing broken since fix for T2372 was merged
Closed, ResolvedPublic

Description

After T2372 fix was merged (https://github.com/vyos/vyos-1x/pull/383), IPv6 EUI-64 addressing was broken, interfaces got assigned 'fe80::/64' when they shouldn't have, when interfaces got disabled their addresses got deleted from the interface so services that checked them failed to commit (eg dhcp-server).

Fix is in progress:

  • revert to old behavior of just putting interface to admin down when disabled without deleting addresses
  • fix bug where the default return value of a function was a list that got assigned by reference and not copied so changing one list variable changed also other unrelated variables
  • migrate vif, vif_s and vif_c variables from lists to dicts with VLAN IDs as keys and VLAN configs as values

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202005040117
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

jjakob changed the task status from Open to In progress.May 5 2020, 1:25 PM
jjakob triaged this task as Unbreak Now! priority.
jjakob created this task.
jjakob created this object in space S1 VyOS Public.
03:42:04  DEBUG - Traceback (most recent call last):
03:42:04  DEBUG -   File "/usr/libexec/vyos/conf_mode/interfaces-wireless.py", line 810, in <module>
03:42:04  DEBUG -     verify(c)
03:42:04  DEBUG -   File "/usr/libexec/vyos/conf_mode/interfaces-wireless.py", line 621, in verify
03:42:04  DEBUG -     verify_vlan_config(wifi)
03:42:04  DEBUG -   File "/usr/lib/python3/dist-packages/vyos/ifconfig_vlan.py", line 155, in verify_vlan_config
03:42:04  DEBUG -     for vif in config['vif'].values():
03:42:04  DEBUG - AttributeError: 'list' object has no attribute 'values'
03:42:04  DEBUG - 
03:42:04  DEBUG - 
03:42:04  DEBUG - 
03:42:04  DEBUG - [[interfaces wireless wlan10]] failed
03:42:04  DEBUG - Commit failed

Forgot to migrate other interfaces to use the new functions. Will prepare a new PR.

jjakob moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 6:20 AM
erkin removed a subscriber: Active contributors.